Fix encrypted backup restore block-size initialization - #13689
Merged
tclinkenbeard-oai merged 2 commits intoJul 13, 2026
Merged
Conversation
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
akankshamahajan15
approved these changes
Jul 13, 2026
akankshamahajan15
left a comment
akankshamahajan15
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing it
akankshamahajan15
pushed a commit
to akankshamahajan15/foundationdb
that referenced
this pull request
Jul 23, 2026
…rd/fix-encrypted-backup-restore-block-size Fix encrypted backup restore block-size initialization
akankshamahajan15
pushed a commit
to akankshamahajan15/foundationdb
that referenced
this pull request
Jul 23, 2026
…rd/fix-encrypted-backup-restore-block-size Fix encrypted backup restore block-size initialization
akankshamahajan15
pushed a commit
to akankshamahajan15/foundationdb
that referenced
this pull request
Jul 23, 2026
…rd/fix-encrypted-backup-restore-block-size Fix encrypted backup restore block-size initialization
akankshamahajan15
pushed a commit
to akankshamahajan15/foundationdb
that referenced
this pull request
Jul 23, 2026
…rd/fix-encrypted-backup-restore-block-size Fix encrypted backup restore block-size initialization
akankshamahajan15
added a commit
that referenced
this pull request
Aug 5, 2026
* Add GCM Authentication Tag to Encrypted Backup Files * Merge pull request #13689 from tclinkenbeard-oai/dev/tclinkenbeard/fix-encrypted-backup-restore-block-size Fix encrypted backup restore block-size initialization --------- Co-authored-by: Trevor Clinkenbeard <tclinkenbeard@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize the encryption block size from backup metadata before describing encrypted backup files. This prevents restores opened without an explicit block size from hitting the GCM trailing-block assertion. Adds a focused regression test covering this restore path.