Enable -Wunused-variable - #1446
Merged
Merged
Conversation
atn34
commented
Apr 9, 2019
ajbeamon
reviewed
Apr 9, 2019
atn34
force-pushed
the
unused-variable-warning
branch
from
April 9, 2019 20:02
b8221b8 to
9634ca2
Compare
atn34
commented
Apr 9, 2019
jzhou77
reviewed
Apr 10, 2019
jzhou77
reviewed
Apr 10, 2019
jzhou77
reviewed
Apr 10, 2019
jzhou77
reviewed
Apr 10, 2019
atn34
force-pushed
the
unused-variable-warning
branch
from
April 10, 2019 16:37
1118b8d to
52d5af7
Compare
Collaborator
Author
|
I addressed all review comments, and also rewrote the history to remove the changes that were reverted to preserve git blame integrity. PTAL. |
Collaborator
|
LGTM and thanks for doing this! |
jzhou77
approved these changes
Apr 10, 2019
ajbeamon
reviewed
Apr 16, 2019
ajbeamon
left a comment
ajbeamon
left a comment
Contributor
There was a problem hiding this comment.
I was hoping to actually get to review this before it got merged, but I'll submit my comments anyway.
| for(auto &versionedPageSet : children) { | ||
| debug_printf("%p version: Page id=%lld\n", THIS, versionedPageSet.first); | ||
| for(auto &boundaryPage : versionedPageSet.second) { | ||
| (void)boundaryPage; |
Contributor
There was a problem hiding this comment.
This is maybe out of scope of this PR, but I wonder if this whole loop shouldn't be made conditional on debugging.
atn34
added a commit
to atn34/foundationdb
that referenced
this pull request
Apr 16, 2019
Collaborator
Author
|
Followed up in #1464 |
atn34
added a commit
to atn34/foundationdb
that referenced
this pull request
Apr 16, 2019
ajbeamon
added a commit
that referenced
this pull request
Apr 16, 2019
Address review comments from #1446
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1255