Suppress pkl-gradle POM metadata warning - #1807
Open
RushikeshGandhmal wants to merge 1 commit into
Open
Conversation
The plugin depends on the shaded pkl-tools runtime variant. Gradle module metadata preserves its bundling attribute, but a Maven POM cannot represent it fully. Suppress the runtimeElements compatibility warning for the pluginMaven publication without changing either generated metadata file.
Contributor
Author
|
Hi @bioball, please find my testing below, I verified the reported behavior manually using the same POM-generation command before and after the change. On a clean, current
After applying this change, the same command succeeds without that warning:
The generated Maven POM and Gradle module metadata were also compared with the baseline and are byte-for-byte identical. The change only suppresses the known compatibility warning; it does not alter the published metadata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #1743
Summary
The
pkl-gradleplugin intentionally requests the shadowedpkl-toolsruntime variant. Gradle module metadata preserves that bundling attribute, but Maven POM metadata cannot represent it fully, so Gradle reports a compatibility warning when generating thepluginMavenPOM.Suppress the warning only for the
runtimeElementsvariant ofpluginMaven. Other publications and variants are unaffected.Verification
upstream/maincheckout.:pkl-gradle:validatePom,:pkl-gradle:spotlessCheck, and:pkl-gradle:buildsuccessfully.--dry-run; no artifacts were uploaded.git diff --check.