[Windows] use _dupenv_s instead of getenv #250
Conversation
getenv generates a warning on windows.
|
Thanks, @damuellen! Are you able to test this with one of the supported shells under Windows? I know we don't have automated tests for this, but it would be good to know the status. |
|
cc @compnerd |
|
Honestly, I'm not sure if it's too important to test (beyond compiling). The windows environment doesn't have a SHELL environment variable, your shell is either cmd or powershell. |
| var length: Int = 0 | ||
| guard _dupenv_s(&buffer, &length, "SHELL") != 0, let shellVar = buffer else { return nil } | ||
| let shellParts = String(cString: shellVar).split(separator: "/") | ||
| free(buffer) |
There was a problem hiding this comment.
I would swap the two things, doing a defer { free(buffer) } and then just returning the processed value. However, the separator is unlikely to be / and more likely to be \ if there was such a variable, though it could be either.
🤔 In that case, given that |
|
Yeah, returning nil for the time being sounds reasonable. For powershell, it may be possible to auto complete, but I don't know about cmd. |
|
I will close this pr, and create a new own which simply return nil on windows. |
3 participants
getenv generates a warning on windows.