Skip to content

[Windows] Don't try to detect shell. #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2020
Merged

[Windows] Don't try to detect shell. #253

merged 3 commits into from
Nov 2, 2020

Conversation

@damuellen
Copy link
Contributor

@damuellen damuellen commented Oct 25, 2020

Replacement for: #250

@natecook1000
Copy link
Member

natecook1000 commented Oct 25, 2020

Thanks for this, @damuellen!

@natecook1000
Copy link
Member

natecook1000 commented Oct 25, 2020

@swift-ci Please smoke test

@natecook1000
Copy link
Member

natecook1000 commented Oct 25, 2020

@swift-ci Please test

1 similar comment
@natecook1000
Copy link
Member

natecook1000 commented Oct 28, 2020

@swift-ci Please test

natecook1000
natecook1000 reviewed Oct 28, 2020
View reviewed changes
@damuellen @natecook1000
Update Sources/ArgumentParser/Completions/CompletionsGenerator.swift
7302cb1 
Co-authored-by: Nate Cook <natecook@apple.com>
@natecook1000
Copy link
Member

natecook1000 commented Nov 2, 2020

@swift-ci Please test

@natecook1000 natecook1000 merged commit d633b43 into apple:main Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natecook1000 natecook1000 natecook1000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@damuellen @natecook1000