Make StreamLogHandler initializers public - #477
Merged
Conversation
Signed-off-by: subhramit <subhramit.bb@live.in>
Contributor
Author
|
The failing CI checks seem to be a toolchain/package-config mismatch and unrelated to my changes. |
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
kukushechkin
requested changes
Jun 25, 2026
Signed-off-by: subhramit <subhramit.bb@live.in>
kukushechkin
approved these changes
Jun 25, 2026
kukushechkin
left a comment
kukushechkin
left a comment
Contributor
There was a problem hiding this comment.
@subhramit Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
StreamLogHandlerinitializers public.Motivation:
Closes #273
Modifications:
Promote the two stream-accepting initializers from
internaltopublic. Also as a result, their stream parameter is spelled out asany TextOutputStream & Sendablerather than the internal_SendableTextOutputStreamtypealias, which cannot appear in a public signature.The private stored property and the internal typealias are otherwise unchanged.The internal typealias has been completely removed as it was only used to store the stream, and the private stored property is updated to use the spelled-out type.Also updates the docc documentation accordingly.
Result:
Users would be able to construct a
StreamLogHandlerwith their ownTextOutputStreamimplementation, reusing the existing logic to format log messages and prettify metadata instead of reimplementing them.