Fix sequence number bounds check for RETIRE_CONNECTION_ID frames#37
Merged
Conversation
Per RFC 9000 §19.16, a RETIRE_CONNECTION_ID frame with a sequence number greater than any previously sent to the peer must be treated as a connection error. However, the logic incorrectly included the largest previously seen sequence number as well leading to incorrect connection errors. - Replace `guard` with `if` so the condition matches the text. - Update the text as the RFC says "MUST" not "MAY"
glbrntt
requested review from
agnosticdev,
kkuk24,
rpaulo and
tfpauly
as code owners
tfpauly
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 9000 §19.16, a RETIRE_CONNECTION_ID frame with a sequence number greater than any previously sent to the peer must be treated as a connection error.
However, the logic incorrectly included the largest previously seen sequence number as well leading to incorrect connection errors.
guardwithifso the condition matches the text.