Rename everything. #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
force-pushed
the
cb-remove-open-from-names
branch
from
7139255 to
5a9d61a
Compare
Motivation: Unfortunately, it turns out that the word "OpenSSL" just ended up everwhere in our codebase, including in the names of our types. This was, in hindsight, a bit of an unfortunate bit of naming. We should take this breaking opportunity to give these types better names. In particular, we should stop identifying them as belonging to any library other than this one, "NIOSSL". That way we become somewhat independent of the specific way that this library is implemented. Modifications: Renamed a bunch of stuff. Internal types mostly got their names changed from OpenSSL->BoringSSL. External types generally got their names changed to "NIOSSL", except where those types directly reflected a BoringSSL implementation detail, specifically in the errors. The main name changes are: SSLContext -> NIOSSLContext OpenSSLError -> BoringSSLError NIOOpenSSLError -> NIOSSLError OpenSSLInternalError -> BoringSSLInternalError OpenSSLPKCS12Bundle -> NIOSSLPKCS12Bundle OpenSSLPassphraseCallback -> NIOSSLPassphraseCallback OpenSSLPassphraseSetter -> NIOSSLPassphraseSetter OpenSSLPrivateKey -> NIOSSLPrivateKey OpenSSLPublicKey -> NIOSSLPublicKey OpenSSLCertificate -> NIOSSLCertificate OpenSSLVerificationResult -> NIOSSLVerificationResult OpenSSLVerificationCallback -> NIOSSLVerificationCallback OpenSSLCertificateSource -> NIOSSLCertificateSource OpenSSLPrivateKeySource -> NIOSSLPrivateKeySource OpenSSLTrustRoots -> NIOSSLTrustRoots OpenSSLSerializationFormats -> NIOSSLSerializationFormats OpenSSLHandler -> NIOSSLHandler OpenSSLClientHandler -> NIOSSLClientHandler OpenSSLServerHandler -> NIOSSLServerHandler Oh, and renamed the module too: it's now NIOSSL, instead of NIOOpenSSL. Result: Users have better names for things.
Lukasa
force-pushed
the
cb-remove-open-from-names
branch
from
5a9d61a to
c15f225
Compare
tbartelmess
added a commit
to tbartelmess/nio-postgres
that referenced
this pull request
Mar 4, 2019
apple/swift-nio-ssl#75 changed the name name of the NIOOpenSSL package to NIOSSL, as well as a changing the name of a bunch of classes and structs. This PR updates NIOPostgres to it can build against the master branch of swift-nio-ssl.
tanner0101
pushed a commit
to vapor/postgres-nio
that referenced
this pull request
Mar 5, 2019
apple/swift-nio-ssl#75 changed the name name of the NIOOpenSSL package to NIOSSL, as well as a changing the name of a bunch of classes and structs. This PR updates NIOPostgres to it can build against the master branch of swift-nio-ssl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Unfortunately, it turns out that the word "OpenSSL" just ended up everwhere
in our codebase, including in the names of our types. This was, in hindsight,
a bit of an unfortunate bit of naming.
We should take this breaking opportunity to give these types better names.
In particular, we should stop identifying them as belonging to any library
other than this one, "NIOSSL". That way we become somewhat independent of
the specific way that this library is implemented.
Modifications:
Renamed a bunch of stuff. Internal types mostly got their names changed
from OpenSSL->BoringSSL. External types generally got their names changed
to "NIOSSL", except where those types directly reflected a BoringSSL
implementation detail, specifically in the errors.
The main name changes are:
SSLContext -> NIOSSLContext
OpenSSLError -> BoringSSLError
NIOOpenSSLError -> NIOSSLError
OpenSSLInternalError -> BoringSSLInternalError
OpenSSLPKCS12Bundle -> NIOSSLPKCS12Bundle
OpenSSLPassphraseCallback -> NIOSSLPassphraseCallback
OpenSSLPassphraseSetter -> NIOSSLPassphraseSetter
OpenSSLPrivateKey -> NIOSSLPrivateKey
OpenSSLPublicKey -> NIOSSLPublicKey
OpenSSLCertificate -> NIOSSLCertificate
OpenSSLVerificationResult -> NIOSSLVerificationResult
OpenSSLVerificationCallback -> NIOSSLVerificationCallback
OpenSSLCertificateSource -> NIOSSLCertificateSource
OpenSSLPrivateKeySource -> NIOSSLPrivateKeySource
OpenSSLTrustRoots -> NIOSSLTrustRoots
OpenSSLSerializationFormats -> NIOSSLSerializationFormats
OpenSSLHandler -> NIOSSLHandler
OpenSSLClientHandler -> NIOSSLClientHandler
OpenSSLServerHandler -> NIOSSLServerHandler
Oh, and renamed the module too: it's now NIOSSL, instead of NIOOpenSSL.
Result:
Users have better names for things.