-
Notifications
You must be signed in to change notification settings - Fork 720
Add EventLoopFuture fold function #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,201 @@ class EventLoopFutureTest : XCTestCase { | |
| let f = EventLoopFuture<Void>(eventLoop: eventLoop, error: EventLoopFutureTestError.example, file: #file, line: #line) | ||
| XCTAssertTrue(f.isFulfilled) | ||
| } | ||
|
|
||
| func testFoldWithMultipleEventLoops() throws { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @weissi Does this test suffice for multiple
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, thanks! |
||
| let nThreads = 3 | ||
| let eventLoopGroup = MultiThreadedEventLoopGroup(numThreads: nThreads) | ||
| defer { | ||
| XCTAssertNoThrow(try eventLoopGroup.syncShutdownGracefully()) | ||
| } | ||
|
|
||
| let eventLoop0 = eventLoopGroup.next() | ||
| let eventLoop1 = eventLoopGroup.next() | ||
| let eventLoop2 = eventLoopGroup.next() | ||
|
|
||
| XCTAssert(eventLoop0 !== eventLoop1) | ||
| XCTAssert(eventLoop1 !== eventLoop2) | ||
| XCTAssert(eventLoop0 !== eventLoop2) | ||
|
|
||
| let f0: EventLoopFuture<[Int]> = eventLoop0.submit { [0] } | ||
| let f1s: [EventLoopFuture<Int>] = (1...4).map { id in eventLoop1.submit { id } } | ||
| let f2s: [EventLoopFuture<Int>] = (5...8).map { id in eventLoop2.submit { id } } | ||
|
|
||
| var fN = f0.fold(f1s) { (f1Value: [Int], f2Value: Int) -> EventLoopFuture<[Int]> in | ||
| XCTAssert(eventLoop0.inEventLoop) | ||
| return eventLoop1.newSucceededFuture(result: f1Value + [f2Value]) | ||
| } | ||
|
|
||
| fN = fN.fold(f2s) { (f1Value: [Int], f2Value: Int) -> EventLoopFuture<[Int]> in | ||
| XCTAssert(eventLoop0.inEventLoop) | ||
| return eventLoop2.newSucceededFuture(result: f1Value + [f2Value]) | ||
| } | ||
|
|
||
| let allValues = try fN.wait() | ||
| XCTAssert(fN.eventLoop === f0.eventLoop) | ||
| XCTAssert(fN.isFulfilled) | ||
| XCTAssertEqual(allValues, [0, 1, 2, 3, 4, 5, 6, 7, 8]) | ||
| } | ||
|
|
||
| func testFoldWithSuccessAndAllSuccesses() throws { | ||
| let eventLoop = EmbeddedEventLoop() | ||
| let secondEventLoop = EmbeddedEventLoop() | ||
| let f0 = eventLoop.newSucceededFuture(result: [0]) | ||
|
|
||
| let futures: [EventLoopFuture<Int>] = (1...5).map { (id: Int) in secondEventLoop.newSucceededFuture(result: id) } | ||
|
|
||
| let fN = f0.fold(futures) { (f1Value: [Int], f2Value: Int) -> EventLoopFuture<[Int]> in | ||
| XCTAssert(eventLoop.inEventLoop) | ||
| return secondEventLoop.newSucceededFuture(result: f1Value + [f2Value]) | ||
| } | ||
|
|
||
| let allValues = try fN.wait() | ||
| XCTAssert(fN.eventLoop === f0.eventLoop) | ||
| XCTAssert(fN.isFulfilled) | ||
| XCTAssertEqual(allValues, [0, 1, 2, 3, 4, 5]) | ||
| } | ||
|
|
||
| func testFoldWithSuccessAndOneFailure() throws { | ||
| struct E: Error {} | ||
| let eventLoop = EmbeddedEventLoop() | ||
| let secondEventLoop = EmbeddedEventLoop() | ||
| let f0: EventLoopFuture<Int> = eventLoop.newSucceededFuture(result: 0) | ||
|
|
||
| let promises: [EventLoopPromise<Int>] = (0..<100).map { (_: Int) in secondEventLoop.newPromise() } | ||
| var futures = promises.map { $0.futureResult } | ||
| let failedFuture: EventLoopFuture<Int> = secondEventLoop.newFailedFuture(error: E()) | ||
| futures.insert(failedFuture, at: futures.startIndex) | ||
|
|
||
| let fN = f0.fold(futures) { (f1Value: Int, f2Value: Int) -> EventLoopFuture<Int> in | ||
| XCTAssert(eventLoop.inEventLoop) | ||
| return secondEventLoop.newSucceededFuture(result: f1Value + f2Value) | ||
| } | ||
|
|
||
| _ = promises.map { $0.succeed(result: 0) } | ||
| XCTAssert(fN.isFulfilled) | ||
| do { | ||
| _ = try fN.wait() | ||
| XCTFail("should've thrown an error") | ||
| } catch _ as E { | ||
| /* good */ | ||
| } catch let e { | ||
| XCTFail("error of wrong type \(e)") | ||
| } | ||
| } | ||
|
|
||
| func testFoldWithSuccessAndEmptyFutureList() throws { | ||
| let eventLoop = EmbeddedEventLoop() | ||
| let f0 = eventLoop.newSucceededFuture(result: 0) | ||
|
|
||
| let futures: [EventLoopFuture<Int>] = [] | ||
|
|
||
| let fN = f0.fold(futures) { (f1Value: Int, f2Value: Int) -> EventLoopFuture<Int> in | ||
| XCTAssert(eventLoop.inEventLoop) | ||
| return eventLoop.newSucceededFuture(result: f1Value + f2Value) | ||
| } | ||
|
|
||
| let summationResult = try fN.wait() | ||
| XCTAssert(fN.isFulfilled) | ||
| XCTAssertEqual(summationResult, 0) | ||
| } | ||
|
|
||
| func testFoldWithFailureAndEmptyFutureList() throws { | ||
| struct E: Error {} | ||
| let eventLoop = EmbeddedEventLoop() | ||
| let f0: EventLoopFuture<Int> = eventLoop.newFailedFuture(error: E()) | ||
|
|
||
| let futures: [EventLoopFuture<Int>] = [] | ||
|
|
||
| let fN = f0.fold(futures) { (f1Value: Int, f2Value: Int) -> EventLoopFuture<Int> in | ||
| XCTAssert(eventLoop.inEventLoop) | ||
| return eventLoop.newSucceededFuture(result: f1Value + f2Value) | ||
| } | ||
|
|
||
| XCTAssert(fN.isFulfilled) | ||
| do { | ||
| _ = try fN.wait() | ||
| XCTFail("should've thrown an error") | ||
| } catch _ as E { | ||
| /* good */ | ||
| } catch let e { | ||
| XCTFail("error of wrong type \(e)") | ||
| } | ||
| } | ||
|
|
||
| func testFoldWithFailureAndAllSuccesses() throws { | ||
| struct E: Error {} | ||
| let eventLoop = EmbeddedEventLoop() | ||
| let secondEventLoop = EmbeddedEventLoop() | ||
| let f0: EventLoopFuture<Int> = eventLoop.newFailedFuture(error: E()) | ||
|
|
||
| let promises: [EventLoopPromise<Int>] = (0..<100).map { (_: Int) in secondEventLoop.newPromise() } | ||
| let futures = promises.map { $0.futureResult } | ||
|
|
||
| let fN = f0.fold(futures) { (f1Value: Int, f2Value: Int) -> EventLoopFuture<Int> in | ||
| XCTAssert(eventLoop.inEventLoop) | ||
| return secondEventLoop.newSucceededFuture(result: f1Value + f2Value) | ||
| } | ||
|
|
||
| _ = promises.map { $0.succeed(result: 1) } | ||
| XCTAssert(fN.isFulfilled) | ||
| do { | ||
| _ = try fN.wait() | ||
| XCTFail("should've thrown an error") | ||
| } catch _ as E { | ||
| /* good */ | ||
| } catch let e { | ||
| XCTFail("error of wrong type \(e)") | ||
| } | ||
| } | ||
|
|
||
| func testFoldWithFailureAndAllUnfulfilled() throws { | ||
| struct E: Error {} | ||
| let eventLoop = EmbeddedEventLoop() | ||
| let secondEventLoop = EmbeddedEventLoop() | ||
| let f0: EventLoopFuture<Int> = eventLoop.newFailedFuture(error: E()) | ||
|
|
||
| let promises: [EventLoopPromise<Int>] = (0..<100).map { (_: Int) in secondEventLoop.newPromise() } | ||
| let futures = promises.map { $0.futureResult } | ||
|
|
||
| let fN = f0.fold(futures) { (f1Value: Int, f2Value: Int) -> EventLoopFuture<Int> in | ||
| XCTAssert(eventLoop.inEventLoop) | ||
| return secondEventLoop.newSucceededFuture(result: f1Value + f2Value) | ||
| } | ||
|
|
||
| XCTAssert(fN.isFulfilled) | ||
| do { | ||
| _ = try fN.wait() | ||
| XCTFail("should've thrown an error") | ||
| } catch _ as E { | ||
| /* good */ | ||
| } catch let e { | ||
| XCTFail("error of wrong type \(e)") | ||
| } | ||
| } | ||
|
|
||
| func testFoldWithFailureAndAllFailures() throws { | ||
| struct E: Error {} | ||
| let eventLoop = EmbeddedEventLoop() | ||
| let secondEventLoop = EmbeddedEventLoop() | ||
| let f0: EventLoopFuture<Int> = eventLoop.newFailedFuture(error: E()) | ||
|
|
||
| let futures: [EventLoopFuture<Int>] = (0..<100).map { (_: Int) in secondEventLoop.newFailedFuture(error: E()) } | ||
|
|
||
| let fN = f0.fold(futures) { (f1Value: Int, f2Value: Int) -> EventLoopFuture<Int> in | ||
| XCTAssert(eventLoop.inEventLoop) | ||
| return secondEventLoop.newSucceededFuture(result: f1Value + f2Value) | ||
| } | ||
|
|
||
| XCTAssert(fN.isFulfilled) | ||
| do { | ||
| _ = try fN.wait() | ||
| XCTFail("should've thrown an error") | ||
| } catch _ as E { | ||
| /* good */ | ||
| } catch let e { | ||
| XCTFail("error of wrong type \(e)") | ||
| } | ||
| } | ||
|
|
||
| func testAndAllWithAllSuccesses() throws { | ||
| let eventLoop = EmbeddedEventLoop() | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but what if we're dealing with different event loops?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weissi It doesn't matter.
and'sthenwill execute on f1's event loop, and the firstf1isself, and then the future returned fromcombiningFunctionwill be moved over to thef1loop (because that's howthenworks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, that makes sense. Thank you!