Tests: ignore XCTest manifest on newer Swift #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is motivated by the desire to build the test suite on Windows. Newer versions of SPM have test discovery which obviates the test manifest, which incidentally repairs the build on Windows while adopting newer functionality and reducing management complexity.
Collaborator
Author
|
@swift-ci please test |
Contributor
|
If we bump the tools version, could we remove the file? |
Collaborator
Author
|
Yes, I was conflicted about that. It seems that it would be better to remove the file - it’s unlikely it will be maintained, test discovery is now default even, so why keep it? But perhaps there are older environments that need to be supported? |
Contributor
|
We'll likely be bumping the tools version soon. I want to get a |
Collaborator
Author
|
That is fair; what should we do in the meantime? I would like to repair the test suite for Windows. |
|
@milseman Is your plan to bump the tools version all the way to 5.7? |
Member
|
@swift-ci test |
etcwilde
pushed a commit
to etcwilde/swift-system
that referenced
this pull request
May 13, 2025
* [OrderedDictionary] modifyValue → updateValue * Update CMakeLists.txt
etcwilde
pushed a commit
to etcwilde/swift-system
that referenced
this pull request
May 13, 2025
* [OrderedDictionary] modifyValue → updateValue * Update CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by the desire to build the test suite on Windows.
Newer versions of SPM have test discovery which obviates the test
manifest, which incidentally repairs the build on Windows while adopting
newer functionality and reducing management complexity.