fix: mirrored orientation in GetPhaseTransform - #109
Open
Rubeanie wants to merge 1 commit into
Open
Conversation
Rubeanie
marked this pull request as ready for review
September 3, 2026 09:18
Rubeanie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Unity-to-PHASE conversion flipped the Z axis on one side only, so the rotation it produced was a mirror image.
Position was unaffected, which is why point sources sounded fine, but directional sources and oriented listeners were reflected front to back under pitch and roll.
Apply the flip on both sides so the rotation is a proper one. The matrix is transposed here because the native side reads it transposed.
Testing
Tested on device - Apple Vision Pro (visionOS 26)