Multiple items #97
Merged
Multiple items #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify Blinn export Material ui redo
dictoon
approved these changes
Dec 7, 2017
Member
dictoon
left a comment
dictoon
left a comment
There was a problem hiding this comment.
Some local variable names look suspicious and I suggest fixing this even though but it has no real impact.
Great work otherwise, thanks!
| if current_layer.glass_reflection_tint_tex != '' and current_layer.glass_reflection_tint_use_tex: | ||
| glass_reflection_tint_tex = bpy.data.textures[current_layer.glass_reflection_tint_tex] | ||
| layout.prop(glass_reflection_tint_tex.image.colorspace_settings, "name", text="Color Space") | ||
| specular_tex = bpy.data.textures[current_layer.glass_reflection_tint_tex] |
Member
There was a problem hiding this comment.
I think this variable name is wrong (it's reused in many places). Not that it really makes a difference, but until we refactor all this code to reduce duplication, we should probably use correct names.
Member
There was a problem hiding this comment.
I propose to fix this after the fact. I'll merge the PR right away so we can start testing.
Member
Author
There was a problem hiding this comment.
Yeah I’m doing a lot of copy/paste for the BSDF additions. All of the actual property calls are updated but sometimes I miss the variables inside the functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plastic BRDF
Material ui redo
Material property cleanup