IMPLEMENT: fix open-in-editor spawning new VS Code window (issue #245)#246
Merged
DaveHudson merged 2 commits intomainfrom May 1, 2026
Conversation
Previously used vscode://file<path> URL scheme which reuses the existing VS Code window. Now spawns `code --new-window <path>` via child_process so a new window is always opened. Falls back to the URL scheme if the CLI is unavailable (e.g. code not in PATH on macOS without shell integration). Extracted openInEditor(path, runCli) with an injected CliRunner so the new-window behaviour is directly verifiable without Electron or child_process mocks. Files changed: - apps/desktop/src/main/ipc/shell.ts - apps/desktop/tests/main/shell-ipc.test.ts (new) No blockers.
spawnCode resolved the promise on any close event, including non-zero exit codes, so a failed `code` CLI invocation would never trigger the shell.openExternal fallback. Fix it to reject on non-zero or signal termination so the fallback fires as intended. Add three new tests: no-fallback on success, fallback on CLI error, and path-with-spaces passthrough. Mock electron at the system boundary so the fallback path is actually exercisable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #245