Fix collector mode helpers#266
Merged
Merged
Conversation
The collector reads the action name from `appsignal.action_name`, but `set_root_name` only emitted `appsignal.root_name`, which the collector ignores. In collector mode, emit `appsignal.action_name` so root names set this way are honored instead of falling back to the OpenTelemetry span name.
In collector mode, `set_name` now updates the OpenTelemetry span name instead of setting the `appsignal.name` attribute. The collector uses the span name as-is and its enrichers can't override it, so the attribute is unnecessary there. The agent still gets the attribute, which it honors as a hard override over its semantic convention name extraction.
|
✔️ All good! |
When `set_sql_body` is used in collector mode, emit attributes following the OpenTelemetry Semantic Conventions for Database Spans, as the collector expects, rather than the `appsignal.sql_body` attribute that the agent expects.
unflxw
force-pushed
the
fix-collector-mode-helpers
branch
from
May 28, 2026 07:24
9e39953 to
2b413fb
Compare
tombruijn
approved these changes
May 28, 2026
lipskis
approved these changes
May 29, 2026
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
This is a message from the daily scheduled checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit action_name attribute in collector mode
The collector reads the action name from
appsignal.action_name,but
set_root_nameonly emittedappsignal.root_name, which thecollector ignores. In collector mode, emit
appsignal.action_nameso root names set this way are honored instead of falling back to
the OpenTelemetry span name.
Update span name directly in collector mode
In collector mode,
set_namenow updates the OpenTelemetry spanname instead of setting the
appsignal.nameattribute. Thecollector uses the span name as-is and its enrichers can't override
it, so the attribute is unnecessary there. The agent still gets the
attribute, which it honors as a hard override over its semantic
convention name extraction.
Sanitise SQL queries in collector mode
When
set_sql_bodyis used in collector mode, emit attributesfollowing the OpenTelemetry Semantic Conventions for Database Spans,
as the collector expects, rather than the
appsignal.sql_bodyattribute that the agent expects.