Skip to content

Fix the hidden column list is not bounded and overflows in height (#981) #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nikhil-Nandagopal merged 1 commit into from
Oct 8, 2020
Merged

Fix the hidden column list is not bounded and overflows in height (#981) #1024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion app/client/src/components/designSystems/appsmith/TableColumnsVisibility.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ const DropDownWrapper = styled.div`
z-index: 1;
border-radius: 4px;
border: 1px solid ${Colors.ATHENS_GRAY};
max-height: 500px;
max-width: 400px;
overflow: hidden scroll;
`;

const OptionWrapper = styled.div<{ selected: boolean }>`
Expand All @@ -45,6 +48,13 @@ const OptionWrapper = styled.div<{ selected: boolean }>`
}
`;

const StyledOption = styled.div`
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
max-width: 90%;
`

const ButtonWrapper = styled.div`
display: flex;
width: 100%;
Expand Down Expand Up @@ -132,7 +142,7 @@ const TableColumnsVisibility = (props: TableColumnsVisibilityProps) => {
}}
className="t--table-column-visibility-column-toggle"
>
<div className="option-title">{option.Header}</div>
<StyledOption className="option-title">{option.Header}</StyledOption>
<VisibilityIcon visible={!option.isHidden} />
</OptionWrapper>
))}
Expand Down