Skip to content

Fix-RTE was not initialised when it is mounted 2nd time - #1076

Merged
hetunandu merged 2 commits into
releasefrom
fix/rich-text-editor
Oct 19, 2020
Merged

Fix-RTE was not initialised when it is mounted 2nd time#1076
hetunandu merged 2 commits into
releasefrom
fix/rich-text-editor

Conversation

@vicky-primathon

Copy link
Copy Markdown
Contributor

Description

Remove RTE instance from tinymce editor instances when component is unmounted. Tinymce internally keeps a list of editors initialized. And we need to remove editor from that list when component is unmounted.

Fixes #785

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually tested that RTE is initialised every time a page is loaded.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vicky-primathon vicky-primathon changed the title Remove RTE intance from tinymce editor instances when component is un… Fix-RTE was not initialised when it is mounted 2nd time Oct 8, 2020
@Nikhil-Nandagopal

Copy link
Copy Markdown
Contributor

@vicky-primathon I see some tests failing

@riodeuno

Copy link
Copy Markdown
Contributor

Duplicate of #690. @Nikhil-Nandagopal Please close the one you find inappropriate.

@hetunandu
hetunandu merged commit 3ae032d into release Oct 19, 2020
@hetunandu
hetunandu deleted the fix/rich-text-editor branch October 19, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Rich Text editor Format changes on deployment

4 participants