Skip to content

fix(organization-service): add check that organization is not empty - #1120

Merged
hetunandu merged 2 commits into
appsmithorg:releasefrom
daniloff200:restrict-empty-orgs-via-http
Nov 2, 2020
Merged

fix(organization-service): add check that organization is not empty#1120
hetunandu merged 2 commits into
appsmithorg:releasefrom
daniloff200:restrict-empty-orgs-via-http

Conversation

@daniloff200

@daniloff200 daniloff200 commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

Description

Add check, to restrict creating empty organizations with http request

Fixes #774 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniloff200 daniloff200 changed the title fix(organiztion-service): add check that organization is not empty fix(organization-service): add check that organization is not empty Oct 9, 2020
@hetunandu
hetunandu requested a review from mohanarpit October 22, 2020 13:15
@mohanarpit

Copy link
Copy Markdown
Member

@daniloff200 Are you still working on this PR? I'm asking because I haven't seen any activity in the past few days.

Can you please resolve the review comments and update this PR?

@daniloff200

Copy link
Copy Markdown
Contributor Author

@mohanarpit yeah, I will do that at the weekend.

@daniloff200

Copy link
Copy Markdown
Contributor Author

@mohanarpit done :)

@hetunandu
hetunandu merged commit 26da9ce into appsmithorg:release Nov 2, 2020
@daniloff200
daniloff200 deleted the restrict-empty-orgs-via-http branch November 2, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] It is possible to generate a Organization with no name.

5 participants