Skip to content

Prevent input component cursor getting reset using asyncControlledInput#2802

Merged
rishabhsaxena merged 4 commits into
releasefrom
fix-caret-position-reset-login
Feb 3, 2021
Merged

Prevent input component cursor getting reset using asyncControlledInput#2802
rishabhsaxena merged 4 commits into
releasefrom
fix-caret-position-reset-login

Conversation

@rishabhsaxena

@rishabhsaxena rishabhsaxena commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

Description

Add option to use asyncControlledInput for ads text input
Prevent caret position getting reset when input value prop updates are delayed

Fixes #2485

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rishabhsaxena rishabhsaxena changed the title option to use asyncControlledInput for ads text input Prevent input component cursor getting reset using asyncControlledInput Feb 2, 2021
hetunandu
hetunandu previously approved these changes Feb 3, 2021
@rishabhsaxena
rishabhsaxena merged commit 5da3b01 into release Feb 3, 2021
@rishabhsaxena
rishabhsaxena deleted the fix-caret-position-reset-login branch February 3, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Cursor always jumps to the end in sign-up form

2 participants