fix: consolidated API: fix Mockito error

[sumitsum]

Description

• fix Mockito error
  • JUnit TC for consolidated API were commented out because of this. This PR enables the test cases again.
• add a Junit TC to test error response when anonymous user tries to access private application.

PR fixes following issue(s)

Fixes #29988

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

• JUnit

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• PR is being merged under a feature flag

QA activity:

• Speedbreak features have been covered
• Test plan covers all impacted features and areas of interest
• Test plan has been peer reviewed by project stakeholders and other QA members
• Manually tested functionality on DP
• We had an implementation alignment call with stakeholders post QA Round 2
• Cypress test cases have been added and approved by SDET/manual QA
• Added Test Plan Approved label after Cypress tests were reviewed
• Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

• Tests
  • Updated test cases to align with the latest application logic and features.
  • Added imports for various classes and interfaces.
  • Modified annotations for testing and mocking.
  • Adjusted test methods to accommodate the modified logic and functionality.

[coderabbitai]

Walkthrough

Walkthrough

The updates involve fixing JUnit test cases for consolidated APIs, which previously failed on Enterprise Edition (EE) due to Mockito-related errors but worked on Community Edition (CE). The tests have been re-enabled after resolving these issues. Additionally, new test cases have been added to verify sub-API authorization for different user roles, such as anonymous users and API users.

Changes

File Path	Change Summary
.../appsmith-server/src/test/java/com/appsmith/server/services/ConsolidatedAPIServiceImplTest.java	Added imports, updated annotations, and modified test methods to fix Mockito errors and add new authorization tests.

Assessment against linked issues

Objective	Addressed	Explanation
Fix JUnit test cases for consolidated APIs throwing Mockito errors on EE (#29988)	✅
Re-enable the previously disabled JUnit test cases after fixing (#29988)	✅
Add JUnit test cases for sub-api authorization using anonymous_user and api_user (#29988)	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.