fix: Refactoring bindings logic for module instances to fix the naming issue#30574
Merged
ankitakinger merged 2 commits intoreleasefrom Jan 24, 2024
Merged
fix: Refactoring bindings logic for module instances to fix the naming issue#30574ankitakinger merged 2 commits intoreleasefrom
ankitakinger merged 2 commits intoreleasefrom
Conversation
Contributor
WalkthroughThe recent updates include adding a new selector function, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
Bug
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
Author
|
/ok-to-test tags="@tag.All" |
|
Whoa, @tag.All spotted in your test suite! 🚀 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7636439898. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7636439898.
|
…o fix/bindings-for-module-instances
Contributor
Author
|
/ok-to-test tags="@tag.All" |
|
Whoa, @tag.All spotted in your test suite! 🚀 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7636972943. |
ApekshaBhosale
approved these changes
Jan 24, 2024
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7636972943.
|
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7636972943. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring bindings logic for module instances to fix the naming issue
PR fixes following issue(s)
Fixes #30575
Type of change
Testing
How Has This Been Tested?
Checklist:
Dev activity
QA activity:
Test Plan Approvedlabel after Cypress tests were reviewedTest Plan Approvedlabel after JUnit tests were reviewedSummary by CodeRabbit
EntityPropertiescomponent for improved performance and reliability.