Skip to content

Fix: Fork application improvements#3509

Merged
akash-codemonk merged 2 commits into
releasefrom
fix/enhancements-fork
Mar 12, 2021
Merged

Fix: Fork application improvements#3509
akash-codemonk merged 2 commits into
releasefrom
fix/enhancements-fork

Conversation

@akash-codemonk

@akash-codemonk akash-codemonk commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

Description

  • Show fork modal while returning back after signing in
  • Show loaders where required.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually with applications/6034ff4472504469bd50ed42/pages/6034ff4472504469bd50ed44

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@akash-codemonk
akash-codemonk merged commit 4995288 into release Mar 12, 2021
@akash-codemonk
akash-codemonk deleted the fix/enhancements-fork branch March 12, 2021 07:44
sondermanish pushed a commit that referenced this pull request Mar 6, 2024
@Aishwarya-U-R
test: Cypress | Flaky fix RBACFunctionalTests/OthersTabPermission_spe…
0984499 
…c.js (#3509)

## Description
- This PR fixes the RBACFunctionalTests/OthersTabPermission_spec.js
flakyness in CI runs (before hook, created new
adminSettings.EnableAuditlogs())
- Skipping tests 5th, 6th to be fixed later

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rishabhsaxena rishabhsaxena rishabhsaxena approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akash-codemonk @rishabhsaxena