Skip to content

Clone Page feature inside an application - #357

Merged
trishaanand merged 3 commits into
releasefrom
feature/page-cloning
Aug 19, 2020
Merged

Clone Page feature inside an application#357
trishaanand merged 3 commits into
releasefrom
feature/page-cloning

Conversation

@trishaanand

Copy link
Copy Markdown
Contributor

No description provided.

…nside the same application and is in unpublished state.
@mohanarpit
mohanarpit self-requested a review August 19, 2020 09:49
@trishaanand
trishaanand merged commit efab105 into release Aug 19, 2020
@trishaanand
trishaanand deleted the feature/page-cloning branch August 19, 2020 09:50
@sharat87

Copy link
Copy Markdown
Member

Hey @trishaanand, sorry just got around to this. It looks like we are calling LayoutActionService.updateLayout so that the actions inside onLoad lists are updated to point to the new actions. However, this doesn't update the actions inside publishedLayoutOnLoadActions. So, action IDs inside publishedLayoutOnLoadActions would still be pointing to actions in the source page. They have to be manually mapped and updated.

Otherwise looks good to have been merged. Ignore if this is already handled.

@trishaanand

Copy link
Copy Markdown
Contributor Author

Hey @sharat87 : The new page created would be in unpublished zone. So none of the published fields would be set including the published on load actions and published dsl.

@mohanarpit

Copy link
Copy Markdown
Member

@all-contributors Please add @trishaanand and @sharat87 for their contributions to code, infrastructure and ideas.

@allcontributors

Copy link
Copy Markdown
Contributor

@mohanarpit

I've put up a pull request to add @trishaanand! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants