Skip to content

FEATURE-2111 : Show/Hide Table Controls#4551

Closed
wmdev0808 wants to merge 1 commit into
releasefrom
feature/2111-control-header-options-visibilities
Closed

FEATURE-2111 : Show/Hide Table Controls#4551
wmdev0808 wants to merge 1 commit into
releasefrom
feature/2111-control-header-options-visibilities

Conversation

@wmdev0808

@wmdev0808 wmdev0808 commented May 17, 2021

Copy link
Copy Markdown
Contributor

Description

  • Add the header options section for the visibility on the property pane
  • Render conditionally the header part based on the setting

Fixes #2111

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed
// Code coverage diff between base branch:release and head branch: feature/2111-control-header-options-visibilities 
Status File % Stmts % Branch % Funcs % Lines
🔴 app/client/src/components/designSystems/appsmith/TableComponent/TableStyledWrappers.tsx 35.37 (0) 16.67 (-0.14) 0 (0) 35.37 (0)

@wmdev0808
wmdev0808 requested review from riodeuno and somangshu May 17, 2021 23:43
@somangshu

Copy link
Copy Markdown
Contributor

The problem is solved to an extent, but we have 2 new issues here.

  • The pagination element in Table Options Header is not visible anymore
    Pagination element is hidden

  • When we bind the table data to a query/API the behaviour is different when the Table Options Header is hidden, the last row seems to be empty.

Screen.Recording.2021-05-18.at.3.00.54.PM.mov

This issue was originally taken up in PR #4424.

@somangshu somangshu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my above comment

@somangshu
somangshu removed the request for review from riodeuno May 19, 2021 11:12
@somangshu

Copy link
Copy Markdown
Contributor

Closing this, Taken up in a new PR #4580

@somangshu somangshu closed this May 19, 2021
@somangshu
somangshu deleted the feature/2111-control-header-options-visibilities branch May 19, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show/Hide Table Controls

2 participants