Skip to content

[Feature] new nav sniping mode#5746

Merged
pranavkanade merged 119 commits into
releasefrom
feature/new-nav-sniping-mode
Jul 26, 2021
Merged

[Feature] new nav sniping mode#5746
pranavkanade merged 119 commits into
releasefrom
feature/new-nav-sniping-mode

Conversation

@pranavkanade

@pranavkanade pranavkanade commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

Description

In addition to suggested widgets, this will allow user to directly bind data to one of the widgets from canvas.

Fixes #4543
Fixes #4544

depends on #5755

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manually
  • Cypress tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feature/new-nav-sniping-mode 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 51.84 (-0.11) 33.7 (-0.09) 29.74 (-0.28) 52.47 (-0.13)
🔴 app/client/src/actions/actionActions.ts 67.71 (-0.03) 100 (0) 0 (0) 54.84 (-0.16)
🟢 app/client/src/actions/propertyPaneActions.ts 87.5 (1.79) 100 (0) 60 (10) 77.78 (-2.22)
🟢 app/client/src/components/designSystems/appsmith/PositionedContainer.tsx 100 (0) 81.25 (2.68) 100 (0) 100 (0)
🟢 app/client/src/components/editorComponents/DraggableComponent.tsx 82.54 (0.57) 59.52 (0.98) 73.33 (0) 82.46 (0.64)
🟢 app/client/src/components/editorComponents/ResizableComponent.tsx 59.57 (0.87) 16.95 (1.43) 63.64 (0) 59.57 (0.87)
✨ 🆕 app/client/src/components/editorComponents/SnipeableComponent.tsx 77.78 27.27 33.33 77.78
✨ 🆕 app/client/src/components/editorComponents/ActionRightPane/Connections.tsx 39.66 31.25 0 39.66
✨ 🆕 app/client/src/components/editorComponents/ActionRightPane/SuggestedWidgets.tsx 40.54 30.77 0 41.67
✨ 🆕 app/client/src/components/editorComponents/ActionRightPane/index.tsx 33.72 25 0 36.71
🔴 app/client/src/components/editorComponents/Debugger/EntityDependecies.tsx 35.14 (3.77) 25.81 (-14.19) 0 (0) 36.11 (2.07)
🔴 app/client/src/components/editorComponents/WidgetNameComponent/SettingsControl.tsx 92.5 (-1.62) 75 (-10.71) 88.89 (0) 92.5 (-1.62)
🔴 app/client/src/components/editorComponents/WidgetNameComponent/index.tsx 80 (-1.13) 59.18 (-4.23) 90.91 (0.91) 79.31 (-1.08)
🟢 app/client/src/constants/DefaultTheme.tsx 96.3 (0.04) 89.47 (0) 85.71 (0) 95.65 (0.05)
🟢 app/client/src/constants/messages.ts 69.21 (-0.13) 100 (0) 6.96 (-0.35) 76.34 (0.6)
🔴 app/client/src/icons/ControlIcons.tsx 57.14 (-0.14) 100 (0) 11.76 (-0.24) 57.14 (-0.14)
🟢 app/client/src/pages/Editor/EditorHeader.tsx 89.83 (0.41) 56.86 (1.3) 75 (-1.92) 89.29 (0.51)
🔴 app/client/src/pages/Editor/GlobalHotKeys.tsx 70.45 (-1.5) 39.13 (0) 60.61 (-0.68) 69.05 (-1.46)
🟢 app/client/src/pages/Editor/ToggleModeButton.tsx 64.75 (0) 26.15 (0.78) 40 (0) 63.28 (0)
✨ 🆕 app/client/src/pages/Editor/APIEditor/ApiRightPane.tsx 45.83 47.06 0 48.84
🔴 app/client/src/pages/Editor/APIEditor/Form.tsx 37.04 (-1) 43.75 (-4.17) 0 (0) 38.71 (-1.55)
🟢 app/client/src/pages/Editor/Explorer/Widgets/useNavigateToWidget.ts 90.48 (0.24) 75 (0) 100 (0) 92.5 (0.19)
🔴 app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx 45.1 (0.66) 44.25 (-1.46) 0 (0) 47.26 (0.68)
🟢 app/client/src/reducers/uiReducers/editorReducer.tsx 20.29 (1.17) 0 (0) 16.67 (3.63) 20.29 (1.17)
🔴 app/client/src/sagas/ActionSagas.ts 11.46 (-0.07) 0.98 (0) 4 (-0.17) 13.91 (-0.11)
✨ 🆕 app/client/src/sagas/SnipingModeSagas.ts 17.27 4 40 17.92
🔴 app/client/src/sagas/WidgetOperationSagas.tsx 44.05 (0) 30.53 (-0.19) 49.43 (0) 44.41 (0.08)
🟢 app/client/src/sagas/index.tsx 91.67 (0.18) 60 (0) 100 (0) 93.48 (0.15)
🟢 app/client/src/selectors/editorSelectors.tsx 64.86 (0.72) 55.77 (3.69) 50 (1.06) 62.5 (0.32)
🔴 app/client/src/utils/AppsmithUtils.tsx 45.81 (-0.56) 23.26 (0) 27.03 (-2.7) 41.29 (-0.65)
🔴 app/client/src/utils/autocomplete/TernServer.ts 50.59 (-0.24) 39.41 (-0.84) 36.21 (0) 54.77 (-0.27)
🟢 app/client/src/utils/hooks/dragResizeHooks.tsx 76.79 (0.86) 30 (7.78) 60 (0) 76.09 (1.09)
🟢 app/client/src/widgets/BaseWidget.tsx 79.51 (0.7) 41.86 (0) 78.13 (0.71) 78.63 (0.75)
app/client/src/pages/Editor/APIEditor/DatasourceList.tsx 48.78 46.67 0 51.35

pranavkanade and others added 30 commits July 5, 2021 01:00
@pranavkanade

Copy link
Copy Markdown
Contributor Author

@akash-codemonk the inspect entity spec is failing here - https://dashboard.cypress.io/projects/eyxvp8/runs/8019/overview

@pranavkanade

Copy link
Copy Markdown
Contributor Author

/ok-to-test sha=69c5fa2

rishabhsaxena
rishabhsaxena previously approved these changes Jul 23, 2021
rishabhsaxena
rishabhsaxena previously approved these changes Jul 23, 2021
@vercel

vercel Bot commented Jul 26, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/appsmith-community/appsmith/GoUaJYoK94uxjMWPpr158knckU8J
✅ Preview: https://appsmith-git-feature-new-nav-sniping-mode-appsmith-community.vercel.app

@pranavkanade
pranavkanade merged commit 3547976 into release Jul 26, 2021
@pranavkanade
pranavkanade deleted the feature/new-nav-sniping-mode branch July 26, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants