fix: added container wrapper component to handle styles#6476
Conversation
marks0351
left a comment
There was a problem hiding this comment.
Great job on adding the style features!!
Pls add a docs update PR for these changes.
when border is more than a certain value the widget overflows widget boundaries. it should not be the case.
|
@marks0351 Here also updated Border styles for Text Widget for issue #4419 |
marks0351
left a comment
There was a problem hiding this comment.
@vibhandikyash when a container radius is set very large the container goes away which is fine and is expected but the area below container becomes unaccessible because of the div overflow.
Also when border radius is set to a large number it does not work as expected with text widget. text widget starts to overflow.
somangshu
left a comment
There was a problem hiding this comment.
Approving to run tests
|
@vibhandikyash related test has failed, Please check |
|
Rerunning all jobs here, |
|
Failed again, @vibhandikyash please check this locally and let me know |
somangshu
left a comment
There was a problem hiding this comment.
LGTM, @rishabhsaxena thanks for the help here.
Approving to run the tests
|
@marks0351 @vibhandikyash here is my feedback Container widget:
Text widget:
|
…rations for container and form widget
…horg/appsmith into FIX/2587-container-style-support
marks0351
left a comment
There was a problem hiding this comment.
@vibhandikyash the text widget and container still overflows when border width given is high.
|
@vibhandikyash Verified the container style functionality and looks good to me |
|
@vibhandikyash Working fine for text widget too. |

Description
Fixes #2587
Fixes #4419
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🟢 Total coverage has increased