Skip to content

fix: table column order and isVisible#6521

Merged
somangshu merged 2 commits into
releasefrom
fix/Table-visible-column-not-saving
Aug 11, 2021
Merged

fix: table column order and isVisible#6521
somangshu merged 2 commits into
releasefrom
fix/Table-visible-column-not-saving

Conversation

@Tooluloope

@Tooluloope Tooluloope commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change.

Fixes #6480

Fixes #6454

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/Table-visible-column-not-saving 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 53.36 (0) 34.81 (0) 31.49 (-0.01) 53.91 (0)
🔴 app/client/src/sagas/WidgetOperationSagas.tsx 44.22 (-0.07) 30.89 (0) 48.86 (-0.57) 44.52 (-0.07)

@Tooluloope
Tooluloope requested a review from riodeuno August 11, 2021 06:05
@vivekverma2312

Copy link
Copy Markdown

@Tooluloope When I tried to bind table from widget suggestion from query/API screen the error is coming.
Unexpected token { in JSON at position 1
https://www.loom.com/share/6285aac2e93240829c38ca334d42e65d

@vivekverma2312

Copy link
Copy Markdown

@Tooluloope When I tried to bind table from widget suggestion from query/API screen the error is coming.
Unexpected token { in JSON at position 1
https://www.loom.com/share/6285aac2e93240829c38ca334d42e65d

getting above error on all the action on property pane

@somangshu
somangshu removed their request for review August 11, 2021 10:12
@somangshu
somangshu merged commit 38e1d66 into release Aug 11, 2021
@somangshu
somangshu deleted the fix/Table-visible-column-not-saving branch August 11, 2021 14:02
@somangshu

Copy link
Copy Markdown
Contributor

@vivekverma2312 can we test this on Release?

Tooluloope added a commit that referenced this pull request Aug 12, 2021
Hot-fixes:
- Table column order reset on page / data refresh
- Table column visible property reset on page / data refresh

(cherry picked from commit 38e1d66)
Tooluloope added a commit that referenced this pull request Aug 12, 2021
Hot-fixes:
- Table column order reset on page / data refresh
- Table column visible property reset on page / data refresh

(cherry picked from commit 38e1d66)
(cherry picked from commit 94d5638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Table's visible columns are not saved [Bug] Table widget, Column order gets reset on page refresh.

4 participants