fix: Show trigger errors in the debugger with widget and property name#6970
Merged
Conversation
rishabhsaxena
previously approved these changes
Aug 30, 2021
…inted-trigger-errors
- Remove unnecassary call to add error - Show better error messages when present
…inted-trigger-errors
akash-codemonk
marked this pull request as draft
September 1, 2021 04:46
akash-codemonk
marked this pull request as ready for review
September 1, 2021 10:43
rishabhsaxena
previously approved these changes
Sep 1, 2021
…inted-trigger-errors
…inted-trigger-errors
…inted-trigger-errors
…inted-trigger-errors
…inted-trigger-errors
…issues where not showing up
rishabhsaxena
previously approved these changes
Sep 13, 2021
rishabhsaxena
left a comment
Contributor
There was a problem hiding this comment.
a couple of queries, rest LGTM
Contributor
|
Also a minor point: should we show the value along with the error in the errors tab? This could be an enhancement |
Contributor
Author
Not sure this would be helpful as these are for trigger fields and these have function calls, so there is no resulting evaluated value of the field. So what could be shown is the code in the field itself. |
…inted-trigger-errors
rishabhsaxena
previously approved these changes
Sep 14, 2021
…inted-trigger-errors
rishabhsaxena
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6340
Fixes #6339
Errors are shown are in the errors tab of the debugger when there is an error on trigger. The error in the debugger gets cleared once the same is triggered succesfully.
Type of change
How Has This Been Tested?
Cypress test
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased