Skip to content

feat: Improved onboarding flow on user signup#7089

Merged
sbalaji1192 merged 13 commits into
releasefrom
feature/signposting-wip
Sep 13, 2021
Merged

feat: Improved onboarding flow on user signup#7089
sbalaji1192 merged 13 commits into
releasefrom
feature/signposting-wip

Conversation

@sbalaji1192

@sbalaji1192 sbalaji1192 commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

Description

This PR introduces a new improved onboarding flow for a new user. Once user signs up, she will be taken to a newly created application with step by step onboarding flow.

Fixes #4057

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: feature/signposting-wip 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.88 (0.44) 36.84 (0.59) 34.39 (0.83) 55.4 (0.4)
🟢 app/client/src/actions/onboardingActions.ts 70.59 (2.85) 100 (0) 9.09 (9.09) 56.52 (4.14)
🟢 app/client/src/actions/pluginActionActions.ts 68 (1) 0 (0) 3.13 (3.13) 56.25 (1.56)
✨ 🆕 app/client/src/actions/widgetSidebarActions.tsx 78.57 100 25 66.67
🟢 app/client/src/components/ads/Button.tsx 92.97 (0.78) 81.05 (2.1) 95.35 (2.33) 93.65 (0.79)
🔴 app/client/src/components/editorComponents/Sidebar.tsx 100 (0) 80 (-20) 100 (0) 100 (0)
✨ 🆕 app/client/src/components/editorComponents/Onboarding/utils.tsx 57.14 100 50 58.33
🟢 app/client/src/constants/messages.ts 75.23 (3.17) 100 (0) 26.15 (10.41) 81.25 (2.94)
🔴 app/client/src/constants/routes.ts 80.34 (-3.2) 39.52 (-1.86) 58.33 (-5.31) 78.43 (-3.26)
🔴 app/client/src/pages/Editor/WidgetSidebar.tsx 83.12 (-1.6) 75 (0) 66.67 (-3.92) 82.67 (-1.62)
🔴 app/client/src/pages/Editor/WidgetsEditor.tsx 93.42 (0.56) 68.57 (-4.76) 100 (0) 93.15 (0.61)
🔴 app/client/src/pages/Editor/utils.ts 39.81 (-2.74) 38.36 (-4.72) 16.67 (-8.33) 41 (-3.32)
🔴 app/client/src/pages/Editor/Explorer/index.tsx 86.96 (-3.95) 50 (0) 100 (0) 86.96 (-3.95)
✨ 🆕 app/client/src/pages/Editor/FirstTimeUserOnboarding/Checklist.tsx 96.24 96.61 92.68 96.24
✨ 🆕 app/client/src/pages/Editor/FirstTimeUserOnboarding/IntroductionModal.tsx 93.33 100 80 92.5
✨ 🆕 app/client/src/pages/Editor/FirstTimeUserOnboarding/Statusbar.tsx 88.89 79.31 83.33 88.64
✨ 🆕 app/client/src/pages/Editor/FirstTimeUserOnboarding/Tasks.tsx 98.44 96.43 91.67 98.39
✨ 🆕 app/client/src/pages/Editor/FirstTimeUserOnboarding/Utils.ts 54.55 100 0 50
✨ 🆕 app/client/src/pages/Editor/FirstTimeUserOnboarding/testUtils.ts 100 100 100 100
🟢 app/client/src/pages/Editor/GeneratePage/components/GeneratePageForm/GeneratePageForm.tsx 17.98 (0.49) 10.59 (-0.12) 0 (0) 20.1 (0.5)
🟢 app/client/src/pages/Editor/IntegrationEditor/ActiveDataSources.tsx 55.17 (1) 85.71 (10.71) 0 (0) 57.14 (0.62)
🔴 app/client/src/reducers/uiReducers/onBoardingReducer.ts 23.08 (-6.92) 100 (0) 0 (0) 23.08 (-6.92)
🔴 app/client/src/sagas/ApplicationSagas.tsx 20.3 (-0.53) 7.46 (-0.48) 9.09 (0) 23.39 (-0.54)
🔴 app/client/src/sagas/OnboardingSagas.ts 17.39 (-0.04) 1.39 (-0.07) 11.11 (-1.13) 17.72 (0.05)
🔴 app/client/src/sagas/PageSagas.tsx 23.87 (-0.2) 5.95 (-0.3) 14.29 (0) 25.7 (-0.11)
🔴 app/client/src/sagas/userSagas.tsx 16.29 (-0.38) 1.45 (-0.11) 5.56 (-0.32) 19.57 (-0.32)
🟢 app/client/src/selectors/dataTreeSelectors.ts 70.37 (3.7) 30 (0) 50 (16.67) 66.67 (4.17)
🟢 app/client/src/selectors/editorSelectors.tsx 70.41 (0.53) 58.73 (1.1) 53.57 (0.84) 67.39 (0.24)
🟢 app/client/src/selectors/entitiesSelector.ts 53.9 (2.05) 9.52 (0.98) 31.93 (3.86) 51.32 (2.23)
🟢 app/client/src/selectors/onboardingSelectors.tsx 95.83 (8.33) 50 (0) 87.5 (37.5) 94.44 (11.11)
🟢 app/client/src/utils/AnalyticsUtil.tsx 29.17 (0) 10.26 (2.57) 30.77 (0) 29.35 (0)
🔴 app/client/src/utils/storage.ts 34.81 (-3.4) 13.64 (0) 12.82 (-5.7) 27.61 (-4.26)
🔴 app/client/src/utils/autocomplete/TernServer.ts 50.47 (-0.24) 38.26 (-0.87) 36.21 (0) 55.08 (-0.27)

@netlify

netlify Bot commented Sep 6, 2021

Copy link
Copy Markdown

A reviewer left a comment:

Upon signing up there is a flash of the home screen for a second or so before landing in the canvas - I assume this is because the user is being redirected. Is it possible to have a load screen instead?

Browser metadata
Path:      /applications/6135c3c980c4345637b24bea/pages/6135c3c980c4345637b24bec/edit
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  2212 x 1214 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@netlify

netlify Bot commented Sep 6, 2021

Copy link
Copy Markdown

A reviewer left a comment:

The first time landing on the canvas doesn't seem to have the MVC modal: https://www.figma.com/file/Ij6Ex7GTokfI7DThsayhkU/First-time-user-onboarding-Wed-30-June-2021?node-id=356%3A4970

Browser metadata
Path:      /applications/6135c3c980c4345637b24bea/pages/6135c3c980c4345637b24bec/edit
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  2212 x 1214 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@netlify

netlify Bot commented Sep 6, 2021

Copy link
Copy Markdown

A reviewer left a comment:

This is an oversight on my part - but it would be useful here to have tooltip hover state that explains why the button is disabled. E.g 'You can only create a query once you have data to query' and 'You can only connect data to widgets once you have added data, widgets and queries'
I'm not sure if the terminology is completely correct.

Is this something we can update?

screenshot

Browser metadata
Path:      /applications/6135c3c980c4345637b24bea/pages/6135c3c980c4345637b24bec/edit/checklist
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  2212 x 1214 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@sbalaji1192
sbalaji1192 force-pushed the feature/signposting-wip branch from 28e102a to e651f8e Compare September 6, 2021 09:57
@LizHamburger

Copy link
Copy Markdown

When a item is complete the text should change from black to a lighter grey - #4B4848 screenshot

Browser metadata
Path:      /applications/6135c3c980c4345637b24bea/pages/6135c3c980c4345637b24bec/edit/checklist
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1678 x 1189 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

LizHamburger commented Sep 7, 2021

Copy link
Copy Markdown

Can we get an SVG for the illustrations instead? They are quite fuzzy
Also, there is a full stop after "Connect queried data to pre-built widgets and customise with Javascript" when there isn't a full stop on any of the other statements
screenshot

Browser metadata
Path:      /applications/61372fee0029405499273206/pages/61372fee0029405499273208/edit
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1330 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

Copy link
Copy Markdown

When closing the browser by accident and then coming back to the link in the history tab my previous progress has disappeared.

In the designs someone can reset the progress within the (?) button. However we should maybe introduce for this first project the step by step doesn't go away until a user completes it or dismisses it on a project.

cc: @areyabhishek

Browser metadata
Path:      /applications/61372fee0029405499273206/pages/61372fee0029405499273208/edit/pages
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1440 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

Copy link
Copy Markdown

Can we use an SVG or a bigger PNG as the image is fuzzy screenshot

Browser metadata
Path:      /applications/613732e50029405499273237/pages/613732e50029405499273239/edit
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1440 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

Copy link
Copy Markdown

Once on canvas, if you add a widget and then delete that widget the original empty state disappears, and we only have 'drag and drop a widget here' while maintaining the 'Connect a data source' in the progress tab.

Should we go back to the original screen with the illustration instead?

CC: @areyabhishek

Browser metadata
Path:      /applications/613732e50029405499273237/pages/613732e50029405499273239/edit
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1440 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

Copy link
Copy Markdown

If start the welcome tour but then change your mind to end it or go back to canvas you then lose the progress bar / onboarding experience.

We should keep the onboarding experience in the application until a user completes it or dismisses it.

cc: @areyabhishek

Browser metadata
Path:      /applications/613734fc0029405499273243/pages/613734fc0029405499273245/edit/pages
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1440 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

Copy link
Copy Markdown

At what point do we say a query has been created? Currently it looks like we mark it as done once someone has clicked the + query button.

Do we want this to be marked as done once they have run a query? What's the pros/cons of both?

screenshot

Browser metadata
Path:      /applications/61373581002940549927324c/pages/61373581002940549927324e/edit/queries/61373615002940549927325a?editName=true&showTemplate=true&from=datasources
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1440 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

LizHamburger commented Sep 7, 2021

Copy link
Copy Markdown

Fuzzy image but also the wrong image.
screenshot

Image should be as per this design:
Screenshot 2021-09-07 at 10 54 46

See design file: https://www.figma.com/file/Ij6Ex7GTokfI7DThsayhkU/First-time-user-onboarding-Wed-30-June-2021?node-id=356%3A4970

Browser metadata
Path:      /applications/61373581002940549927324c/pages/61373581002940549927324e/edit
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1440 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

Copy link
Copy Markdown

The ability to start the process again is missing, see design file: (https://www.figma.com/file/Ij6Ex7GTokfI7DThsayhkU/First-time-user-onboarding-Wed-30-June-2021?node-id=356%3A14142)

screenshot

Browser metadata
Path:      /applications/61373581002940549927324c/pages/61373581002940549927324e/edit/checklist
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1440 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

Copy link
Copy Markdown

When using the wizard to generate the page, the progress bar disappears. See design file:(https://www.figma.com/file/Ij6Ex7GTokfI7DThsayhkU/First-time-user-onboarding-Wed-30-June-2021?node-id=356%3A4970)

screenshot

Browser metadata
Path:      /applications/613739180029405499273284/pages/613739180029405499273286/edit/generate-page/form
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1440 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@LizHamburger

Copy link
Copy Markdown

Could this pop up after a longer period of inactivity? It's distracting having both this and the CTA on the canvas. Can as have it show after 2 minutes of inactivity or if they haven't moved on from the canvas?

screenshot

Browser metadata
Path:      /applications/61373f26449911649b35c0f9/pages/61373f26449911649b35c0fb/edit
Browser:   Chrome 92.0.4515.159 on Mac OS 10.15.7
Viewport:  1440 x 764 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Comment thread app/client/src/components/editorComponents/Sidebar.tsx Outdated
Comment thread app/client/src/pages/Applications/index.tsx Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Checklist.tsx Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Checklist.tsx Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Checklist.tsx
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Checklist.tsx Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Checklist.tsx Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Checklist.tsx Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Checklist.tsx
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Checklist.tsx Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/IntroductionModal.tsx Outdated
rishabhsaxena
rishabhsaxena previously approved these changes Sep 8, 2021

@rishabhsaxena rishabhsaxena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component unit tests on point!
Mostly nitpicks and few general comments regarding using: constants/messages and theme vars for typography, colours, spaces.
Also mentioned a couple of queries

Comment thread app/client/src/pages/Applications/index.tsx Outdated
Comment thread app/client/src/pages/Applications/index.tsx Outdated
Comment thread app/client/src/pages/Applications/index.tsx Outdated
Comment thread app/client/src/pages/Applications/index.tsx Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Checklist.tsx Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/constants.ts Outdated
Comment thread app/client/src/pages/Editor/FirstTimeUserExperience/Statusbar.tsx Outdated
Comment thread app/client/src/sagas/OnboardingSagas.ts Outdated
Comment thread app/client/src/sagas/ApplicationSagas.tsx

@rishabhrathod01 rishabhrathod01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rishabhsaxena
rishabhsaxena previously approved these changes Sep 9, 2021
@github-actions github-actions Bot added the Enhancement New feature or request label Sep 9, 2021
rishabhsaxena
rishabhsaxena previously approved these changes Sep 13, 2021
Comment thread app/client/src/pages/Applications/index.tsx
Comment thread app/client/src/sagas/ApplicationSagas.tsx Outdated
@sbalaji1192
sbalaji1192 merged commit e2ef262 into release Sep 13, 2021
@sbalaji1192
sbalaji1192 deleted the feature/signposting-wip branch September 13, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]Onboarding updates

5 participants