Skip to content

fix: copy paste new widget key generation#7464

Merged
rahulramesha merged 4 commits into
releasefrom
copyPastekeyGeneration
Sep 15, 2021
Merged

fix: copy paste new widget key generation#7464
rahulramesha merged 4 commits into
releasefrom
copyPastekeyGeneration

Conversation

@rahulramesha

@rahulramesha rahulramesha commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

Description

to generate new keys for every time we paste the issue

Fixes #7400
Fixes #7415
Fixes #7423
Fixes #7403

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual UI verification

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: copyPastekeyGeneration 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 54.86 (0) 36.63 (-0.01) 34.23 (0) 55.39 (0)
🔴 app/client/src/utils/autocomplete/TernServer.ts 50.47 (-0.24) 38.26 (-0.87) 36.21 (0) 55.08 (-0.27)

@rahulramesha rahulramesha changed the title fix for copy paste issue fix: copy paste new widget key generation Sep 15, 2021
@github-actions github-actions Bot added the Bug Something isn't working label Sep 15, 2021
@vivekverma2312

Copy link
Copy Markdown

@rahulramesha I am able to repro #7415 on the deploy preview.

@vivekverma2312

vivekverma2312 commented Sep 15, 2021

Copy link
Copy Markdown

@rahulramesha
LOOM DEMO

marks0351
marks0351 previously approved these changes Sep 15, 2021
marks0351
marks0351 previously approved these changes Sep 15, 2021
@vivekverma2312

Copy link
Copy Markdown

@rahulramesha Tested on deploy preview and working fine.

riodeuno
riodeuno previously approved these changes Sep 15, 2021
@vivekverma2312

Copy link
Copy Markdown

@rahulramesha #7403 is also working fine on the DP

@rahulramesha
rahulramesha dismissed stale reviews from riodeuno and marks0351 via 8a21cf2 September 15, 2021 13:05
@rahulramesha
rahulramesha merged commit c4de8fc into release Sep 15, 2021
@rahulramesha
rahulramesha deleted the copyPastekeyGeneration branch September 15, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

4 participants