Skip to content

fix: layout control not working#7502

Merged
pranavkanade merged 4 commits into
releasefrom
fix/layout-control-not-working
Sep 17, 2021
Merged

fix: layout control not working#7502
pranavkanade merged 4 commits into
releasefrom
fix/layout-control-not-working

Conversation

@pranavkanade

@pranavkanade pranavkanade commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Description

Fixing control layout problem.

Fixes #7195
Fixes #7201

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/layout-control-not-working 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 54.89 (0) 36.71 (0) 34.2 (-0.01) 55.42 (0)
🔴 app/client/src/pages/Editor/MainContainerLayoutControl.tsx 85.71 (-0.5) 50 (0) 50 (-7.14) 85.71 (-0.5)
🟢 app/client/src/pages/common/CanvasMultiPointerArena.tsx 17.58 (0.19) 5.13 (0) 0 (0) 18.6 (0.21)
🔴 app/client/src/utils/autocomplete/TernServer.ts 50.47 (-0.24) 38.26 (-0.87) 36.21 (0) 55.08 (-0.27)

@github-actions github-actions Bot added the Bug Something isn't working label Sep 16, 2021

@sbalaji1192 sbalaji1192 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pranavkanade pranavkanade added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 17, 2021
@github-actions github-actions Bot removed the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 17, 2021
@pranavkanade
pranavkanade merged commit 73b795c into release Sep 17, 2021
@pranavkanade
pranavkanade deleted the fix/layout-control-not-working branch September 17, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Release] Extra space is coming at the bottom of the canvas [Bug] [Release]View mode stops working after scrolling the canvas

3 participants