Skip to content

fix: Rating widget crashing when put inside the list widget#7572

Merged
SatishGandham merged 1 commit into
releasefrom
fix/rate-widget-inside-list-issue-7132
Sep 21, 2021
Merged

fix: Rating widget crashing when put inside the list widget#7572
SatishGandham merged 1 commit into
releasefrom
fix/rate-widget-inside-list-issue-7132

Conversation

@SatishGandham

@SatishGandham SatishGandham commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

Rate widget was crashing inside a list widget as it wasn't getting the sanitised value in case of array. This pr ensures it gets the correct value

Fixes #7132

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/rate-widget-inside-list-issue-7132 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 54.78 (-0.01) 36.46 (-0.04) 33.98 (0) 55.33 (-0.02)
🔴 app/client/src/components/formControls/DynamicInputTextControl.tsx 96.55 (1.43) 50 (-16.67) 80 (-3.33) 95.83 (0.83)
🔴 app/client/src/widgets/ListWidget/widget/index.tsx 50 (-0.59) 24.84 (-2.5) 44.44 (0) 48.36 (-0.6)

@SatishGandham SatishGandham changed the title Add array and object_array to list widget validation check Fix the rating widget crashing when put inside the list widget Sep 17, 2021
@SatishGandham SatishGandham changed the title Fix the rating widget crashing when put inside the list widget fix: Rating widget crashing when put inside the list widget Sep 17, 2021
@github-actions github-actions Bot added the Bug Something isn't working label Sep 17, 2021
@vivekverma2312

Copy link
Copy Markdown

@SatishGandham Crash is fixed in the Deploy Preview.

@vivekverma2312

Copy link
Copy Markdown

@SatishGandham Crash is fixed and working fine.

@SatishGandham
SatishGandham merged commit 1423b55 into release Sep 21, 2021
@SatishGandham
SatishGandham deleted the fix/rate-widget-inside-list-issue-7132 branch September 21, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: t.map is not a function

3 participants