feat: progress, loading and error states for git flows, pull button and minor misc changes - #9052
Merged
Conversation
* Add success tick animation * Add Fetch Git Status Loader * Add Loader to show fetching mergeable status * Clear Success animation DP once deploy tab closed
15 tasks
rishabhsaxena
previously approved these changes
Nov 9, 2021
rishabhsaxena
previously approved these changes
Nov 16, 2021
rishabhsaxena
approved these changes
Nov 16, 2021
Contributor
|
/ok-to-test sha=e5fd861 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1466197002. |
rishabhsaxena
changed the title
|
Unable to find test scripts. Please add necessary tests to the PR. |
subrata71
added a commit
that referenced
this pull request
Aug 12, 2026
Linear: https://linear.app/appsmith/issue/APP-15742 ## Why `docker scout cves --only-fixed` on the shipped release image reports 176 fixable vulnerabilities. This is the **CE-owned share of the base image fixes** — the regions of `deploy/docker/base.dockerfile` that CE and EE hold in common. Follows the same ownership split as #41873 (golang bump for the mongo-tools builder), #41808 (Caddy/xcaddy) and #41850 (mongo-tools from source). ## What changed | Change | Effect | |---|---| | Purge `software-properties-common` after `add-apt-repository` | clears **12** findings (7 high) | | mongo-tools Go toolchain `1.26.4` → `1.26.5` | clears the `stdlib` findings | | `x/net` pin `0.55.0` → `0.56.0` (Caddy + mongo-tools) | clears CVE-2026-46600 | | New `x/text` → `0.39.0` pin (Caddy + mongo-tools) | clears CVE-2026-56852 | ### Why `software-properties-common` can go It exists solely for the `add-apt-repository -y ppa:git-core/ppa` call, but drags in `python3-launchpadlib` and with it `python3-cryptography`, `python3-jwt` and `python3-httplib2`. The PPA's sources entry and signing key persist independently of the tool that wrote them, so purging after registration is safe. Verified by building the dependency-package block in isolation: - `python3-cryptography`, `python3-jwt`, `python3-httplib2`, `python3-launchpadlib`, `software-properties-common` — all removed, no `.dist-info` left behind. - `git 2.54.0` (Ubuntu 24.04 ships 2.43, so the PPA is still active), `supervisord 4.2.5`, `mongod 7.0.39`, `mongosh 2.9.2`, `psql 14.23` — all working. - `/etc/apt/sources.list.d/git-core-ubuntu-ppa-noble.sources` still present. ### On the Go pins Verify these with `go version -m <binary>`, not by grepping for `module@version` strings — the grep reports the *pre-replace* version and makes a working pin look inert. Confirmed on the built binaries: ``` caddy dep golang.org/x/text v0.38.0 => v0.39.0 mongodump dep golang.org/x/text v0.39.0 ``` ## Scope EE-only parts of this file — the Keycloak upgrade and the Temporal builder — are handled separately in appsmith-ee#9404, matching the existing split (#9060 for Keycloak, #9155 / #9052 for Temporal). Nothing in this PR touches a region that does not exist in EE, so it should sync cleanly. A full base-image rebuild and rescan was done on the EE side with both halves applied: **123 → 52 findings (−58%)**, high 42 → 20. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated build tooling and platform components to newer versions for improved compatibility and maintenance. * Refined MongoDB tooling builds with more consistent dependency versions. * Reduced unnecessary packages from runtime images after setup, helping keep deployments leaner. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8956 - 3rd sub task
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased