This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Swift: Preserve build path between build and run stages#733
Merged
Conversation
Avoids swift `#file` paths being invalid when used to look up relative paths to resources.
ianpartridge
previously approved these changes
Mar 26, 2020
ianpartridge
previously approved these changes
Mar 27, 2020
ianpartridge
approved these changes
Mar 27, 2020
Contributor
|
I've used the newly released swift stack v0.2.6 and verified that this fixes the errors that I was seeing logged from Kitura's |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids swift
#filepaths being invalid when used to look up relative paths to resources.This was resulting in Kitura's
FileResourceServerlogging errors (due to a design flaw) when the initial landing page is viewed after embedding an existing Kitura project into a project based on theswiftstack.Checklist:
Read the Code of Conduct and Contributing Guidelines.
Followed the commit message guidelines.
Stack adheres to Appsody stack structure.
Modifying an existing stack:
stack.yamlContributing a new stack:
Describe how application dependencies are managed:
Explain how Appsody file watcher is utilized:
Describe other Appsody environment variables defined by the stack image:
Describe any limitations and known issues:
Related Issues: