Investment and transfer improvements by 31b4 · Pull Request #45 · apptrackit/finance

31b4 · 2026-07-14T20:17:59Z

No description provided.

-price per share when bought

…ions

…trol for site.webmanifest

Copilot

Pull request overview

This PR enhances investment and transfer handling by introducing an explicit quote_currency (trading currency) for investment accounts, improving how investment values and transfer purchase details are represented across the UI and API.

Changes:

Add quote_currency support end-to-end (DB migration, API DTOs/validators/services, and client types/UI).
Improve investment valuation and display to handle non-USD listed securities (e.g., EUR quotes) and expose nativeInvested/quoteCurrency for display.
Improve transfer editing behavior (preserve manually-entered received amount and price; allow updating investment-linked transfers with a stored share price).

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
client/src/hooks/useFinanceData.ts	Maps investment transactions and updates investment valuation to respect quote currency when converting to master currency.
client/src/components/investments-module/utils.ts	Adds quote-currency-aware valuation logic and new fields (`nativeInvested`, `quoteCurrency`) in calculated positions.
client/src/components/investments-module/utils.test.ts	Adds a vitest regression test for EUR-listed securities valuation/conversion behavior.
client/src/components/investments-module/types.ts	Extends client investment types to include `quote_currency`, `price`, and new position fields.
client/src/components/investments-module/Investments.tsx	Enhances investment transaction mapping to carry `price` and improve transfer description formatting.
client/src/components/investments-module/InvestmentDetailModal.tsx	Displays values/prices using the position’s quote currency; adjusts date formatting and transfer amount display.
client/src/components/investments-module/HoldingsList.tsx	Updates holdings display to show invested/value/price in the quote currency.
client/src/components/dashboard-module/TransactionList.tsx	Improves transfer auto-calculation/edit preservation and adds price support for investment transfers/edits.
client/src/components/dashboard-module/AccountList.tsx	Adds trading currency selection, persists `quote_currency`, and uses it when converting quote values to USD.
client/public/_headers	Prevents caching of `site.webmanifest`.
api/src/validators/transaction.validator.ts	Allows updating a transaction with an optional positive `price`.
api/src/validators/account.validator.ts	Adjusts account currency validation to support investment holding units and adds `quote_currency` validation.
api/src/tests/validators.test.ts	Adds validator coverage for SHARE/crypto units and invalid cash-account units.
api/src/services/transfer.service.ts	Improves transfer description generation for investment transfers to distinguish share price from FX rate.
api/src/services/transaction.service.ts	Adds support for updating transfers linked to investment transactions, including quantity/price updates and balance reconciliation.
api/src/services/account.service.ts	Persists and updates `quote_currency` consistently.
api/src/repositories/investment-transaction.repository.ts	Adds an `update` method for investment transactions.
api/src/models/Account.ts	Adds `quote_currency` to the Account model.
api/src/middlewares/cors.middleware.ts	Adds `PATCH` to allowed CORS methods.
api/src/mappers/account.mapper.ts	Maps `quote_currency` in both directions (model ↔ DTO).
api/src/dtos/transaction.dto.ts	Adds `price` to `UpdateTransactionDto`.
api/src/dtos/account.dto.ts	Adds `quote_currency` to account create/update/response DTOs.
api/migrations/008-investment-quote-currency.sql	Adds the `quote_currency` column to `accounts`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 7 comments.

    const account: Account = {
      id,
      name: dto.name,
      type: dto.type,
      balance: dto.balance,
      currency: currency.toUpperCase(),
+      quote_currency: dto.quote_currency?.trim().toUpperCase(),
      symbol: dto.symbol,


+    const sourceName = source.replace(/\s-\s.*$/, '').trim()
+    return `${sourceName} (${transaction.quantity} shares @ ${quoteCurrency} ${price.toFixed(2)}/share)${noteSuffix}`
+  }
+  return notes || `${transaction.quantity} shares @ ${quoteCurrency} ${price}`


              <div>
                <div className="text-xs text-muted-foreground">Current Value</div>
                <div className={`text-lg font-bold ${privacyMode === 'hidden' ? 'select-none' : ''}`}>
-                  {privacyMode === 'hidden' ? '••••••' : formatValue(position.displayValue, account)}
+                  {privacyMode === 'hidden' ? '••••••' : formatValue(position.displayValue, account, position.quoteCurrency)}
                </div>
              </div>
              <div>
                <div className="text-xs text-muted-foreground">Net Invested</div>
                <div className={`text-lg font-bold ${privacyMode === 'hidden' ? 'select-none' : ''}`}>
-                  {privacyMode === 'hidden' ? '••••••' : formatValue(position.netInvested, account)}
+                  {privacyMode === 'hidden' ? '••••••' : formatValue(position.nativeInvested, account, position.quoteCurrency)}
                </div>


@@ -102,7 +102,7 @@ export function HoldingsList({
                    </div>
                  )}
                  <div className={`text-sm text-muted-foreground ${privacyMode === 'hidden' ? 'select-none' : ''}`}>
-                    {privacyMode === 'hidden' ? '•••• ' : `${position.account.symbol || position.account.name}`} {position.currentPrice > 0 && `@ $${position.currentPrice.toLocaleString()}`}
+                    {privacyMode === 'hidden' ? '•••• ' : `${position.account.symbol || position.account.name}`} {position.currentPrice > 0 && `@ ${formatValue(position.currentPrice, undefined, position.quoteCurrency)}`}
                  </div>


+                amount_to: amountTo,
+                description: formData.description,
+                date: formData.date,
+                price,
+              }),


 const SUPPORTED_CURRENCIES = ['HUF', 'EUR', 'USD', 'GBP', 'CHF', 'PLN', 'CZK', 'RON']

+function isValidAccountCurrency(data: { type?: 'cash' | 'investment', currency?: string, asset_type?: 'stock' | 'crypto' | 'manual' }) {
+  if (!data.currency) return true


+    nativeInvested = totalInvested - totalWithdrawn
+    netInvested = convertToUsd(nativeInvested, account.quote_currency || quoteCurrency)


31b4 added 5 commits July 14, 2026 10:44

feat: enhance account validation for investment units and currencies

ee5d758

dont auto calc after it was already set

996405a

investment bug fixes:

2c76ec5

-price per share when bought

feat: add quote currency support for investment accounts and transact…

2cd876f

…ions

fix: update CORS headers to include PATCH method and adjust cache con…

3a8dc29

…trol for site.webmanifest

31b4 requested a review from Copilot July 14, 2026 20:17

Copilot started reviewing on behalf of 31b4 July 14, 2026 20:18 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread client/src/components/dashboard-module/TransactionList.tsx

Comment thread client/src/hooks/useFinanceData.ts

Comment thread client/src/components/investments-module/utils.ts Outdated

31b4 and others added 3 commits July 14, 2026 22:27

Potential fix for pull request finding

6c542f4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

66d81b9

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

a88f38a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

31b4 requested a review from Copilot July 14, 2026 20:28

Copilot started reviewing on behalf of 31b4 July 14, 2026 20:29 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

31b4 merged commit 5afb02a into main Jul 14, 2026
5 checks passed

31b4 deleted the investment-and-transfer-improvements branch July 14, 2026 20:40

Navigation Menu

Uh oh!

Investment and transfer improvements - #45

Investment and transfer improvements#45
31b4 merged 8 commits into
mainfrom
investment-and-transfer-improvements

31b4 commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		nativeInvested = totalInvested - totalWithdrawn
		netInvested = convertToUsd(nativeInvested, account.quote_currency \|\| quoteCurrency)

Uh oh!

Conversation

31b4 commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants