Skip to content

Remove php-retry from CI workflows - #12493

Merged
ChiragAgg5k merged 2 commits into
1.9.xfrom
remove-php-retry-workflows
Jun 4, 2026
Merged

Remove php-retry from CI workflows#12493
ChiragAgg5k merged 2 commits into
1.9.xfrom
remove-php-retry-workflows

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

What does this PR do?

Removes the itznotabug/php-retry GitHub Action from CI workflow test steps and runs the same test commands directly with GitHub Actions run steps.

The existing timeout values are preserved with timeout-minutes.

Test Plan

  • Verified no itznotabug or php-retry references remain under .github.
  • Parsed .github/workflows/ci.yml with Ruby YAML.
  • Ran git diff --check.

Related PRs and Issues

  • #XXXX

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@greptile-apps

greptile-apps Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the third-party itznotabug/php-retry GitHub Action from five CI test steps, replacing each with a plain run: step while preserving the existing timeout-minutes values. It also adds the ApiVectorsDB scope trait to three VectorsDB test classes.

  • The retry wrapper (max 2 attempts, 60 s wait) is dropped with no native substitute; all five test jobs now fail immediately on any transient infrastructure hiccup rather than getting a single automatic retry.
  • The ApiVectorsDB trait addition supplies the abstract scope-configuration methods (getApiBasePath, getDatabaseType, etc.) required by the Scope class hierarchy in all three VectorsDB test classes, likely fixing PHP instantiation errors that were silently skipping those tests before.
  • The two changes are logically unrelated and bundled into a single PR, which makes rollback or bisection harder if one half regresses.

Confidence Score: 5/5

Safe to merge; the CI change is a straightforward dependency removal and the VectorsDB trait additions are additive only.

The workflow changes mechanically translate the php-retry action's command field into a run step — the Docker commands themselves are identical, and timeouts are preserved. The VectorsDB PHP changes add a missing trait without touching any existing logic. No correctness regressions are introduced by the diff.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Removes itznotabug/php-retry from 5 test steps and replaces with plain run: steps; timeout-minutes is preserved but the retry/wait logic is not.
tests/e2e/Services/Databases/VectorsDB/DatabasesConsoleClientTest.php Adds use ApiVectorsDB trait, providing the scope configuration methods required by the parent Scope class hierarchy for VectorsDB API routing.
tests/e2e/Services/Databases/VectorsDB/DatabasesCustomClientTest.php Adds use ApiVectorsDB trait alongside the existing DatabasesBase, ProjectCustom, and SideClient traits; no conflicts introduced.
tests/e2e/Services/Databases/VectorsDB/DatabasesCustomServerTest.php Adds use ApiVectorsDB trait alongside DatabasesBase, ProjectCustom, and SideServer; no conflicts or issues.

Reviews (2): Last reviewed commit: "Use VectorsDB API scope in e2e tests" | Re-trigger Greptile

Comment thread .github/workflows/ci.yml
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

✨ Benchmark results

Comparing 1.9.x (before) to remove-php-retry-workflows (after).

Before

Scenario P50 (ms) P95 (ms) Requests RPS
API total 14.1 118.44 185 37.31
Account 23.63 147.48 35 7.73
TablesDB 14.03 26.72 35 9.37
Storage 11.15 49.95 75 19.8
Functions 19.74 30.65 40 10.69

After

Scenario P50 (ms) P95 (ms) Requests RPS
API total 13.56 121.67 185 36.32
Account 27.44 165.46 35 7.52
TablesDB 12.85 17.81 35 9.05
Storage 11.27 48.8 75 19.03
Functions 19.79 33.11 40 10.29

Delta

Scenario P95 delta (ms)
API total +3.23
Account +17.98
TablesDB -8.91
Storage -1.16
Functions +2.46
Top API waits
API request Max wait (ms)
account.sessions.email.create 649.05
account.create 165.35
account.password.update 159.02

@ChiragAgg5k
ChiragAgg5k merged commit 8011639 into 1.9.x Jun 4, 2026
42 of 45 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the remove-php-retry-workflows branch June 4, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants