- 
                Notifications
    
You must be signed in to change notification settings  - Fork 195
 
feat: make upload dropzones mobile-friendly #2480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make upload dropzones mobile-friendly #2480
Conversation
| 
           This PR was not deployed automatically as @HarshMN2345 does not have access to the Railway project. In order to get automatic PR deploys, please add @HarshMN2345 to your workspace on Railway.  | 
    
          ConsoleProject ID:  Sites (2)
 Tip Appwrite has a Discord community with over 16 000 members.  | 
    
          
WalkthroughTwo Svelte pages that render file upload dropzones were refactored for presentation only. Multi-line Stack blocks were replaced with inline, horizontally centered Stacks; instruction text and file-size captions were centered via Typography props. The Tooltip was moved to wrap the info Icon directly and its content is now supplied via a svelte:fragment slot. Inline-flex containers were added to keep the Icon/Tooltip pair inline and vertically aligned. No exported APIs or functional behavior were changed. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
 ✅ Passed checks (2 passed)
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️  Outside diff range comments (1)
src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte (1)
194-196: Missing center alignment on caption.The caption should be center-aligned to match the centered dropzone layout and maintain consistency with the functions file (line 205).
Apply this diff:
-<Typography.Caption variant="400" +<Typography.Caption variant="400" align="center" >Max file size: {readableMaxSize.value + readableMaxSize.unit}</Typography.Caption>
🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/functions/create-function/manual/+page.svelte (1)
188-203: Verify mobile responsiveness and consider extracting shared component.The centered layout improves visual consistency. However, the PR title claims to make dropzones "mobile-friendly," yet the changes primarily center content without introducing mobile-specific responsive features like:
- Touch-friendly target sizes
 - Responsive breakpoints or media queries
 - Mobile-optimized spacing/padding
 - Viewport-based sizing
 Additionally, this dropzone layout is now duplicated between sites and functions. Consider extracting it into a shared component to reduce duplication and ensure consistency.
Can you verify that these changes meaningfully improve mobile usability through manual testing on actual mobile devices? Also, would you like assistance creating a shared dropzone component to eliminate the duplication?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/routes/(console)/project-[region]-[project]/functions/create-function/manual/+page.svelte(1 hunks)src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
 - GitHub Check: e2e
 
🔇 Additional comments (1)
src/routes/(console)/project-[region]-[project]/functions/create-function/manual/+page.svelte (1)
205-208: Good: Caption is properly centered.The caption alignment correctly matches the centered dropzone layout.
        
          
                src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/routes/(console)/project-[region]-[project]/functions/create-function/manual/+page.svelte
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | <Typography.Text variant="l-500" align="center" inline> | ||
| Drag and drop file here or click to upload  | ||
| <Layout.Stack | ||
| style="display: inline-flex; vertical-align: middle;" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does just inline not work? what about the alignItems="center" as well for vertical-align?
| <Typography.Text variant="l-500" align="center" inline> | ||
| Drag and drop file here or click to upload  | ||
| <Layout.Stack | ||
| style="display: inline-flex; vertical-align: middle; margin-inline-start: var(--space-2xs);" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above + how inline start here and not on the other one above?


What does this PR do?
functions sites manual page
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes
Summary by CodeRabbit