Skip to content

feat: make upload dropzones mobile-friendly #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2025
Merged

feat: make upload dropzones mobile-friendly #2480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5acd16
feat: make upload dropzones mobile-friendly
HarshMN2345 Oct 17, 2025
a585271
correct coderabbit suggestion
HarshMN2345 Oct 23, 2025
ae6c3a6
Update +page.svelte
HarshMN2345 Oct 28, 2025
c85f5fd
Update +page.svelte
HarshMN2345 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions ...routes/(console)/project-[region]-[project]/functions/create-function/manual/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,27 +185,24 @@
on:invalid={handleInvalid}>
<Layout.Stack alignItems="center" gap="s">
<Layout.Stack alignItems="center" gap="s">
<Layout.Stack
alignItems="center"
justifyContent="center"
direction="row"
gap="s">
<Typography.Text variant="l-500">
<Layout.Stack alignItems="center" justifyContent="center" inline>
<Typography.Text variant="l-500" align="center" inline>
Drag and drop file here or click to upload
</Typography.Text>
<Tooltip>
<Layout.Stack
style="display: inline-flex; vertical-align: middle;"
Copy link
Member

@ItzNotABug ItzNotABug Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does just inline not work? what about the alignItems="center" as well for vertical-align?

inline
alignItems="center"
justifyContent="center"
inline>
<Icon icon={IconInfo} size="s" />
justifyContent="center">
<Tooltip>
<Icon icon={IconInfo} size="s" />
<svelte:fragment slot="tooltip"
>Only .tar.gz files allowed</svelte:fragment>
</Tooltip>
</Layout.Stack>
<svelte:fragment slot="tooltip"
>Only .tar.gz files allowed</svelte:fragment>
</Tooltip>
</Typography.Text>
</Layout.Stack>
{#if maxSize > 0}
<Typography.Caption variant="400"
<Typography.Caption variant="400" align="center"
>Max file size: {readableMaxSize.value +
readableMaxSize.unit}</Typography.Caption>
{/if}
Expand Down
27 changes: 12 additions & 15 deletions src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,24 +174,21 @@
on:invalid={handleInvalid}>
<Layout.Stack alignItems="center" gap="s">
<Layout.Stack alignItems="center" gap="s">
<Layout.Stack
alignItems="center"
justifyContent="center"
direction="row"
gap="s">
<Typography.Text variant="l-500">
Drag and drop file here or click to upload
</Typography.Text>
<Tooltip>
<Layout.Stack alignItems="center" justifyContent="center" inline>
<Typography.Text variant="l-500" align="center" inline>
Drag and drop file here or click to upload;
<Layout.Stack
style="display: inline-flex; vertical-align: middle;"
inline
alignItems="center"
justifyContent="center"
inline>
<Icon icon={IconInfo} size="s" />
justifyContent="center">
<Tooltip>
<Icon icon={IconInfo} size="s" />
<svelte:fragment slot="tooltip"
>Only .tar.gz files allowed</svelte:fragment>
</Tooltip>
</Layout.Stack>
<svelte:fragment slot="tooltip"
>Only .tar.gz files allowed</svelte:fragment>
</Tooltip>
</Typography.Text>
</Layout.Stack>
{#if maxSize > 0}
<Typography.Caption variant="400"
Expand Down