chore: annotate public MCP tool safety hints - #118
Open
adityaoberai wants to merge 3 commits into
Open
Conversation
adityaoberai
changed the title
adityaoberai
marked this pull request as ready for review
September 10, 2026 14:46
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
appwrite_search_docs sends each query to OpenAI's embeddings API and appwrite_get_context reads live account, organization, project, and service data from the Appwrite API. Both make outbound calls, so open_world_hint=False misrepresented them to clients that honour tool annotations. appwrite_search_tools stays closed-world since it only searches the in-process catalog. Addresses Greptile review feedback on #118. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four public MCP tools omit explicit safety hints, leaving clients without declared read-only, open-world, and destructive behavior. Add all three annotations to each public tool.
Context, catalog search, and documentation search are marked read-only, closed-world, and non-destructive. The generic API executor is marked mutating, open-world, and destructive because it can modify Appwrite resources, send messages, and delete data.
Validation:
--pythonplatform Linux. Default Windows checking reports six existing Unix API errors in docs indexing and telemetry.fcntland one telemetry CPU-gauge failure. The complete suite needs a Linux run.This PR is a draft pending the required checks and review.