Add agent guidance and local ignores#73
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Code Review
This pull request adds project documentation files (AGENTS.md, CLAUDE.md, and GEMINI.md) detailing project overview, key commands, and repository hygiene, alongside updates to .gitignore. The review feedback suggests adding support for Windows developers by ignoring and documenting the Windows executable binary (/execspansql.exe), and correcting the golden file update commands to target the root package instead of using ./... to avoid flag-definition errors in subpackages.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces project documentation and repository configuration files, including a detailed developer guide in AGENTS.md and updated .gitignore rules for local build artifacts. It also adds CLAUDE.md and GEMINI.md to reference the new guide. The review feedback suggests updating GEMINI.md to use the @AGENTS.md import syntax, aligning it with CLAUDE.md to ensure Gemini-based tools can automatically load the shared guidance.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a .gitignore file to manage local build outputs and scratch files, alongside AGENTS.md (and referencing files CLAUDE.md and GEMINI.md) to document the project structure, commands, and repository hygiene. Feedback on the .gitignore file suggests prefixing root-level scratch files with a leading / to prevent them from matching and ignoring legitimate files in subdirectories like testdata/ or examples/.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces project documentation files, including AGENTS.md, CLAUDE.md, and GEMINI.md, which outline the project overview, key commands, integration testing, and repository hygiene. Additionally, the .gitignore file is updated to exclude local build outputs and scratch artifacts. The review feedback suggests a minor readability improvement in AGENTS.md to remove a redundant parenthetical reference.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces project documentation and updates repository configuration. It adds AGENTS.md to provide a comprehensive overview of the execspansql Go CLI, including build/test commands, CI details, and repository hygiene guidelines. Additionally, it adds CLAUDE.md and GEMINI.md referencing the agents documentation, and updates .gitignore to exclude local build artifacts, IDE files, and various scratch files. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
AGENTS.mdwith repository-specific package, test, golden update, integration-test, and release notes.CLAUDE.mdandGEMINI.mdpointers to the shared agent guide.Validation
git diff --checkgo test ./params/... ./jqresult/... ./resultset/...