Skip to content

Adopt github.com/apstndb/protoyaml and freeze internal package#51

Merged
apstndb merged 1 commit into
mainfrom
chore/adopt-protoyaml-module
Jul 8, 2026
Merged

Adopt github.com/apstndb/protoyaml and freeze internal package#51
apstndb merged 1 commit into
mainfrom
chore/adopt-protoyaml-module

Conversation

@apstndb

@apstndb apstndb commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

Two related changes:

  1. Adopt the extracted module for the input path. Switch extract.go and
    extract_test.go from the in-repo github.com/apstndb/spannerplan/protoyaml
    helper to the released module github.com/apstndb/protoyaml v0.1.0. The
    YAMLToJSON, UnmarshalJSON, and Unmarshal signatures are identical, so
    this is a pure import swap with zero behavior change — call sites are
    untouched and tests pass with no golden updates. No replace directive is
    used; the module is pulled from the proxy.

  2. Freeze the in-repo protoyaml package. Add package-level and
    per-function Deprecated: documentation without changing any behavior. The
    package is retained only for downstream compatibility: spanner-mycli pins the
    exact bytes produced by Marshal. That output format was never a designed
    artifact but an accident of reflection-based encoding; new code should use
    the canonical protojson-over-YAML module. The package is slated for removal
    in v0.3.0, once spanner-mycli has migrated. The repo README mention is
    updated accordingly.

Validation

  • go test ./... — pass, zero golden changes
  • golangci-lint run ./... — clean (0 issues)

🤖 Generated with Claude Code

https://claude.ai/code/session_01Du9UR1LPdSXk4wAZr4Nf4g

Switch the query plan input path (extract.go, extract_test.go) from the
in-repo github.com/apstndb/spannerplan/protoyaml helper to the extracted,
released module github.com/apstndb/protoyaml v0.1.0. The YAMLToJSON,
UnmarshalJSON, and Unmarshal signatures are identical, so this is a pure
import swap with zero behavior change (tests pass with no golden updates).

Freeze the in-repo protoyaml package: add package-level and per-function
Deprecated documentation without changing any behavior. The package is
retained only for downstream compatibility (spanner-mycli pins the exact
bytes produced by Marshal). Its Marshal output was never a designed
artifact but an accident of reflection-based encoding; new code should use
the canonical protojson-over-YAML module. The package will be removed in
v0.3.0 once spanner-mycli migrates. README updated accordingly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Du9UR1LPdSXk4wAZr4Nf4g

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates and freezes the internal protoyaml package, replacing its usages in extract.go and extract_test.go with the external github.com/apstndb/protoyaml package. The internal package is marked as deprecated and will be removed in v0.3.0. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@apstndb apstndb merged commit 4e46764 into main Jul 8, 2026
2 checks passed
@apstndb apstndb deleted the chore/adopt-protoyaml-module branch July 8, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant