Adopt github.com/apstndb/protoyaml and freeze internal package#51
Merged
Conversation
Switch the query plan input path (extract.go, extract_test.go) from the in-repo github.com/apstndb/spannerplan/protoyaml helper to the extracted, released module github.com/apstndb/protoyaml v0.1.0. The YAMLToJSON, UnmarshalJSON, and Unmarshal signatures are identical, so this is a pure import swap with zero behavior change (tests pass with no golden updates). Freeze the in-repo protoyaml package: add package-level and per-function Deprecated documentation without changing any behavior. The package is retained only for downstream compatibility (spanner-mycli pins the exact bytes produced by Marshal). Its Marshal output was never a designed artifact but an accident of reflection-based encoding; new code should use the canonical protojson-over-YAML module. The package will be removed in v0.3.0 once spanner-mycli migrates. README updated accordingly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Du9UR1LPdSXk4wAZr4Nf4g
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates and freezes the internal protoyaml package, replacing its usages in extract.go and extract_test.go with the external github.com/apstndb/protoyaml package. The internal package is marked as deprecated and will be removed in v0.3.0. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related changes:
Adopt the extracted module for the input path. Switch
extract.goandextract_test.gofrom the in-repogithub.com/apstndb/spannerplan/protoyamlhelper to the released module
github.com/apstndb/protoyamlv0.1.0. TheYAMLToJSON,UnmarshalJSON, andUnmarshalsignatures are identical, sothis is a pure import swap with zero behavior change — call sites are
untouched and tests pass with no golden updates. No
replacedirective isused; the module is pulled from the proxy.
Freeze the in-repo
protoyamlpackage. Add package-level andper-function
Deprecated:documentation without changing any behavior. Thepackage is retained only for downstream compatibility: spanner-mycli pins the
exact bytes produced by
Marshal. That output format was never a designedartifact but an accident of reflection-based encoding; new code should use
the canonical protojson-over-YAML module. The package is slated for removal
in v0.3.0, once spanner-mycli has migrated. The repo README mention is
updated accordingly.
Validation
go test ./...— pass, zero golden changesgolangci-lint run ./...— clean (0 issues)🤖 Generated with Claude Code
https://claude.ai/code/session_01Du9UR1LPdSXk4wAZr4Nf4g