Skip to content

fix(APP-4550): Align page error internationalization pattern - #765

Merged
cgero-eth merged 3 commits into
mainfrom
fix/APP-4550
Sep 17, 2025
Merged

fix(APP-4550): Align page error internationalization pattern#765
cgero-eth merged 3 commits into
mainfrom
fix/APP-4550

Conversation

@thekidnamedkd

@thekidnamedkd thekidnamedkd commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Description

checked all page error usage to match 'error' key

Task: APP-4550

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Tested locally that all Acceptance Criteria or Expected Outcomes are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@thekidnamedkd
thekidnamedkd requested review from cgero-eth and evanaronson and removed request for cgero-eth September 17, 2025 08:01
@thekidnamedkd thekidnamedkd changed the title WIP fix(APP-4550): Align page error internalization pattern fix(APP-4550): Align page error internalization pattern Sep 17, 2025
@cgero-eth
cgero-eth self-requested a review September 17, 2025 08:17
cgero-eth
cgero-eth previously approved these changes Sep 17, 2025

@cgero-eth cgero-eth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@cgero-eth cgero-eth self-assigned this Sep 17, 2025
@thekidnamedkd thekidnamedkd changed the title fix(APP-4550): Align page error internalization pattern fix(APP-4550): Align page error internationalization pattern Sep 17, 2025
@cgero-eth
cgero-eth merged commit 50079a0 into main Sep 17, 2025
10 checks passed
@cgero-eth
cgero-eth deleted the fix/APP-4550 branch September 17, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants