RepoBadge: update style and fix how it loads repo content#1118
Merged
RepoBadge: update style and fix how it loads repo content#1118
Conversation
bpierre
approved these changes
Oct 10, 2019
Contributor
bpierre
left a comment
bpierre
left a comment
There was a problem hiding this comment.
I’m wondering if we could detect these, and at maybe resize them a bit? But it’s probably not worth putting any effort into this, as icons are going to follow the new format from now on anyway.
Contributor
Author
Yeah, that was my thought too. We're already putting them into a 24x24 container in Btw added @dizzypaty as a reviewer. |
dizzypaty
approved these changes
Oct 10, 2019
dizzypaty
left a comment
dizzypaty
left a comment
There was a problem hiding this comment.
I personally think is nice to see the icons change from one version to another. The old icons do look a bit odd now but, as you mentioned, they match the app menu panel and that's more useful than small ascetic changes.
chadoh
added a commit
to AutarkLabs/aragon
that referenced
this pull request
Oct 23, 2019
* 'master' of github.com:aragon/aragon: (23 commits) Templates: allow disabled, 'coming soon' templates to be opened (aragon#1141) OnboardingTopBar, ErrorScreen: remove unneeded prop types (aragon#1136) Error screen: various fixes (aragon#1132) UI: Replace Checkbox with Switch where applicable (aragon#1135) Local settings: fix two setters (aragon#1129) Build: update to core-js@3 (aragon#1126) Configuration: move prefix from REACT_APP to ARAGON (aragon#1122) Add and configure Jest (aragon#1123) AppIFrame: fix iframe not being mounted in IE (aragon#1125) 0.8.2 (aragon#1120) Onboarding: minor fixes and improvements (aragon#1117) Permissions: refactor to use SearchInput (aragon#1100) Templates: add Fundraising (aragon#1092) Custom labels: update search and DataView (aragon#1077) RepoBadge: update style and fix how it loads repo content (aragon#1118) Onboarding: minor fixes (aragon#1119) Onboarding: clamp value of Voting's support and quorum to their max values (aragon#1114) Onboarding welcome: UI fixes (aragon#1110) Onboarding: remove information about waiting for transactions t… (aragon#1113) docs: add geleeroyale as a contributor (aragon#1112) ...
chadoh
added a commit
to AutarkLabs/aragon
that referenced
this pull request
Oct 23, 2019
* master: (24 commits) add framework for conditionally rendering profiles Templates: allow disabled, 'coming soon' templates to be opened (aragon#1141) OnboardingTopBar, ErrorScreen: remove unneeded prop types (aragon#1136) Error screen: various fixes (aragon#1132) UI: Replace Checkbox with Switch where applicable (aragon#1135) Local settings: fix two setters (aragon#1129) Build: update to core-js@3 (aragon#1126) Configuration: move prefix from REACT_APP to ARAGON (aragon#1122) Add and configure Jest (aragon#1123) AppIFrame: fix iframe not being mounted in IE (aragon#1125) 0.8.2 (aragon#1120) Onboarding: minor fixes and improvements (aragon#1117) Permissions: refactor to use SearchInput (aragon#1100) Templates: add Fundraising (aragon#1092) Custom labels: update search and DataView (aragon#1077) RepoBadge: update style and fix how it loads repo content (aragon#1118) Onboarding: minor fixes (aragon#1119) Onboarding: clamp value of Voting's support and quorum to their max values (aragon#1114) Onboarding welcome: UI fixes (aragon#1110) Onboarding: remove information about waiting for transactions t… (aragon#1113) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously relied on hardcoded images for
RepoBadge. This was primarily useful in showing the same image during an upgrade, but I think it might be more harmful than good.For example:
While the old icons look odd, those are the icons being used on the sidebar and what the user of the old version would expect to see.
To see the difference between the currently deployed version and this version, go to
test.aragonid.eth.