Skip to content

Templates: allow disabled, 'coming soon' templates to be opened#1141

Merged
sohkai merged 1 commit intomasterfrom
template-open-coming-soon-detail
Oct 23, 2019
Merged

Templates: allow disabled, 'coming soon' templates to be opened#1141
sohkai merged 1 commit intomasterfrom
template-open-coming-soon-detail

Conversation

@sohkai
Copy link
Copy Markdown
Contributor

@sohkai sohkai commented Oct 23, 2019

(Slightly older version of the demo: https://imgur.com/a/RU9WEkr).

This allows the template's detail card to be opened, so the user can read more about the template, but does not let them proceed with the actual onboarding.

@sohkai sohkai requested review from bpierre and dizzypaty October 23, 2019 18:48
Copy link
Copy Markdown
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sohkai sohkai changed the title Templates: allow disabled, 'coming soon' templates to have their detail cards open Templates: allow disabled, 'coming soon' templates to be opened Oct 23, 2019
@sohkai sohkai merged commit 5e75347 into master Oct 23, 2019
@sohkai sohkai deleted the template-open-coming-soon-detail branch October 23, 2019 21:50
chadoh added a commit to AutarkLabs/aragon that referenced this pull request Oct 23, 2019
* 'master' of github.com:aragon/aragon: (23 commits)
  Templates: allow disabled, 'coming soon' templates to be opened (aragon#1141)
  OnboardingTopBar, ErrorScreen: remove unneeded prop types (aragon#1136)
  Error screen: various fixes (aragon#1132)
  UI: Replace Checkbox with Switch where applicable (aragon#1135)
  Local settings: fix two setters (aragon#1129)
  Build: update to core-js@3 (aragon#1126)
  Configuration: move prefix from REACT_APP to ARAGON (aragon#1122)
  Add and configure Jest (aragon#1123)
  AppIFrame: fix iframe not being mounted in IE (aragon#1125)
  0.8.2 (aragon#1120)
  Onboarding: minor fixes and improvements (aragon#1117)
  Permissions: refactor to use SearchInput (aragon#1100)
  Templates: add Fundraising (aragon#1092)
  Custom labels: update search and DataView (aragon#1077)
  RepoBadge: update style and fix how it loads repo content (aragon#1118)
  Onboarding: minor fixes (aragon#1119)
  Onboarding: clamp value of Voting's support and quorum to their max values (aragon#1114)
  Onboarding welcome: UI fixes (aragon#1110)
  Onboarding: remove information about waiting for transactions t… (aragon#1113)
  docs: add geleeroyale as a contributor (aragon#1112)
  ...
chadoh added a commit to AutarkLabs/aragon that referenced this pull request Oct 23, 2019
* master: (24 commits)
  add framework for conditionally rendering profiles
  Templates: allow disabled, 'coming soon' templates to be opened (aragon#1141)
  OnboardingTopBar, ErrorScreen: remove unneeded prop types (aragon#1136)
  Error screen: various fixes (aragon#1132)
  UI: Replace Checkbox with Switch where applicable (aragon#1135)
  Local settings: fix two setters (aragon#1129)
  Build: update to core-js@3 (aragon#1126)
  Configuration: move prefix from REACT_APP to ARAGON (aragon#1122)
  Add and configure Jest (aragon#1123)
  AppIFrame: fix iframe not being mounted in IE (aragon#1125)
  0.8.2 (aragon#1120)
  Onboarding: minor fixes and improvements (aragon#1117)
  Permissions: refactor to use SearchInput (aragon#1100)
  Templates: add Fundraising (aragon#1092)
  Custom labels: update search and DataView (aragon#1077)
  RepoBadge: update style and fix how it loads repo content (aragon#1118)
  Onboarding: minor fixes (aragon#1119)
  Onboarding: clamp value of Voting's support and quorum to their max values (aragon#1114)
  Onboarding welcome: UI fixes (aragon#1110)
  Onboarding: remove information about waiting for transactions t… (aragon#1113)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants