DisputableVoting: Implement subgraph#178
Conversation
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=======================================
Coverage 20.43% 20.43%
=======================================
Files 69 69
Lines 1282 1282
Branches 234 234
=======================================
Hits 262 262
Misses 1020 1020
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -0,0 +1,52 @@ | |||
| { | |||
| "name": "@aragon/connect-voting-disputable", | |||
There was a problem hiding this comment.
Should we use the name @aragon/connect-disputable-voting? It seems to be a more common way to refer to it.
| vote.pauseDuration = voteData.value9 | ||
| vote.quietEndingExtendedSeconds = voteData.value10 | ||
| vote.quietEndingSnapshotSupport = castVoterState(voteData.value11) | ||
| vote.script = voteData.value12 |
There was a problem hiding this comment.
I wonder if the latest version of the contract is here: https://github.com/aragon/aragon-apps/blob/disputable_voting_deploy/apps/voting-disputable/contracts/DisputableVoting.sol#L85
I notice the voteData maybe have small differences.
There was a problem hiding this comment.
Yup, I double-checked and it is that one :)
We are also checking it in the tests
3 participants
You can try the subgraph here: aragon-dvoting-rinkeby-staging (there's a limit for the name's length)