DisputableVoting: Implement connector models

[facuspagnuolo]

MERGE AFTER #178

[codecov]

Codecov Report

Merging #181 into master will increase coverage by 5.42%.
The diff coverage is 62.22%.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   27.14%   32.57%   +5.42%     
==========================================
  Files          81       96      +15     
  Lines        1477     1747     +270     
  Branches      251      273      +22     
==========================================
+ Hits          401      569     +168     
- Misses       1076     1178     +102     

Flag	Coverage Δ
#unittests	32.57% <62.22%> (+5.42%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...t-voting-disputable/src/models/DisputableVoting.ts	2.43% <2.43%> (ø)
packages/connect-voting-disputable/src/connect.ts	40.00% <40.00%> (ø)
...onnect-voting-disputable/src/thegraph/connector.ts	47.94% <47.94%> (ø)
...oting-disputable/src/thegraph/parsers/castVotes.ts	66.66% <66.66%> (ø)
...s/connect-voting-disputable/src/models/CastVote.ts	73.33% <73.33%> (ø)
...isputable/src/thegraph/parsers/disputableVoting.ts	80.00% <80.00%> (ø)
...t-voting-disputable/src/thegraph/parsers/voters.ts	83.33% <83.33%> (ø)
...voting-disputable/src/thegraph/parsers/settings.ts	85.00% <85.00%> (ø)
...ct-voting-disputable/src/thegraph/parsers/votes.ts	86.66% <86.66%> (ø)
...kages/connect-voting-disputable/src/models/Vote.ts	92.30% <92.30%> (ø)
... and 20 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3cd199...5599bf1. Read the comment docs.

[0xGabi]

I left a few comments 👍

[0xGabi]

I wonder in which cases we may have a subscription to onDao? 🤔

[facuspagnuolo]

I was kind of inclined to do this due to Pierre's suggestion (see here), however, maybe we can avoid those that may not be necessary

[0xGabi]

Oh, cool, I think we can avoid some of them 👍

[0xGabi]

I wonder if we may use spread syntax to build the settingData we need?

[facuspagnuolo]

not sure I follow :)

[0xGabi]

I mean something like:

const settingData = {
    ...setting,
    votingId: setting.voting.id
}

But maybe if we do that we break the SettingData interface 🤔

[facuspagnuolo]

Yes, it breaks it cause we will include some objects like setting.voting that are not part of the interface, I think at some point we need to do some filtering.

What we could do is to use Object.assign in the entity constructor since it is receiving an object that implements the expected interface

[bpierre]

LGTM 💯