Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Documentation updates#200

Merged
bpierre merged 5 commits intomasterfrom
doc-updates
Aug 13, 2020
Merged

Documentation updates#200
bpierre merged 5 commits intomasterfrom
doc-updates

Conversation

@bpierre
Copy link
Copy Markdown
Contributor

@bpierre bpierre commented Aug 12, 2020

No description provided.

@bpierre bpierre requested a review from 0xGabi August 12, 2020 19:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 12, 2020

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   34.91%   34.91%           
=======================================
  Files          98       98           
  Lines        1793     1793           
  Branches      275      275           
=======================================
  Hits          626      626           
  Misses       1167     1167           
Flag Coverage Δ
#unittests 34.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2aee9e...ca7837b. Read the comment docs.

@bpierre
Copy link
Copy Markdown
Contributor Author

bpierre commented Aug 13, 2020

@0xGabi Merging this now so we can have the website updated, we can review afterwards!

@bpierre bpierre merged commit 12dec7e into master Aug 13, 2020
@bpierre bpierre deleted the doc-updates branch August 13, 2020 09:21

From the point of view of a consumer of your connector, the resulting object will be a function that can get used to connect an app.

For example, this is how app authors can initiate a connection to the Voting app. In this example, `connectVoting` got returned by `createAppConnector()`:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this section a bit confusing. I tried to clarify it a bit on #204

)
}

return new MyAppConnector(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix a small typo here where we should use Voting instead of MyAppConnector. Or did you have something different in mind when writing it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants