Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Docs: Review documentation#204

Merged
0xGabi merged 5 commits intomasterfrom
docs-reviewed
Aug 14, 2020
Merged

Docs: Review documentation#204
0xGabi merged 5 commits intomasterfrom
docs-reviewed

Conversation

@0xGabi
Copy link
Copy Markdown
Contributor

@0xGabi 0xGabi commented Aug 14, 2020

Review the documentation updating a few places.

@0xGabi 0xGabi requested a review from bpierre August 14, 2020 13:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 14, 2020

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   34.96%   34.96%           
=======================================
  Files          98       98           
  Lines        1799     1799           
  Branches      276      276           
=======================================
  Hits          629      629           
  Misses       1170     1170           
Flag Coverage Δ
#unittests 34.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12dec7e...3d7fe4e. Read the comment docs.

@0xGabi 0xGabi mentioned this pull request Aug 14, 2020
Copy link
Copy Markdown
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left a few comments, let me know what you think!

Comment thread docs/advanced/app-connectors.md
Comment thread docs/advanced/app-connectors.md Outdated
Comment thread docs/advanced/app-connectors.md Outdated
Comment thread docs/advanced/app-connectors.md Outdated
Comment thread docs/advanced/app-connectors.md Outdated
Comment thread docs/advanced/app-connectors.md Outdated
Comment thread docs/advanced/app-connectors.md Outdated
Comment thread docs/guides/getting-started.md
@0xGabi 0xGabi merged commit d1349b5 into master Aug 14, 2020
@0xGabi 0xGabi deleted the docs-reviewed branch August 14, 2020 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants