Rust refactor - #1
Merged
Merged
Conversation
added 18 commits
October 30, 2024 20:45
This was referenced Jun 17, 2025
This was referenced Mar 6, 2026
9 tasks
aram-devdocs
added a commit
that referenced
this pull request
Mar 20, 2026
- Add ctypes declarations for 4 new FFI functions to Python _ffi.py (goud_renderer_set/get_coordinate_origin, goud_ui_set_node_position/visible) - Add mark_layout_dirty() calls after set_position and set_visible in FFI to ensure layout recomputation on next update() - Make UiManager::mark_layout_dirty() public for FFI access Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
37 tasks
42 tasks
aram-devdocs
added a commit
that referenced
this pull request
Mar 21, 2026
When max_fixed_steps cap is reached, the remaining accumulator can be much larger than fixed_timestep, producing alpha > 1.0. Clamp with .min(1.0) in both the Rust SDK and FFI paths. Add assertion in test_accumulator_max_steps_cap to verify the invariant. Addresses Claude review blocker #1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.