Skip to content

test: v3.1.1 talking-stick ignoreOtherMentions proof - #152

Merged
aram-devdocs merged 1 commit into
mainfrom
test/issue-151-ignore-other-mentions-proof
Apr 29, 2026
Merged

test: v3.1.1 talking-stick ignoreOtherMentions proof#152
aram-devdocs merged 1 commit into
mainfrom
test/issue-151-ignore-other-mentions-proof

Conversation

@aram-devdocs

Copy link
Copy Markdown
Owner

Closes #151

Verification

  • git diff --stat
  • git diff -- CHANGELOG.md
  • Confirmed - v3.1.1 ignoreOtherMentions proof appears exactly once under ## [Unreleased] / ### Added
  • Confirmed no released changelog sections were changed (released_section_headings=0 in this worktree)

@github-actions

Copy link
Copy Markdown
Contributor

I have everything I need to write the review. Let me compose it now.


Code review summary

PR: #152test: v3.1.1 talking-stick ignoreOtherMentions proof
Author: aram-devdocs
Base: main


Blockers

# Severity File Line Issue Suggestion
None

No Rust code changed; all Rust-specific blocker checks are N/A.


Warnings

# Severity File Line Issue Suggestion
1 Warn CHANGELOG.md 15 Entry v3.1.1 ignoreOtherMentions proof is a bot-protocol test artifact, not a user-visible product change. CLAUDE.md §"Workflow expectations" is explicit: update CHANGELOG under ## [Unreleased] only for user-visible changes. Accept as-is only because v3 autonomous full-flow proof and v3 ACP-allowed proof are already merged under the same heading — the pattern is clearly intentional for workflow-testing purposes. Flag the entire trio for cleanup before the next release cut.
2 Warn PR title Commit type test: conventionally denotes test-code changes; this is a changelog (doc/chore) edit. Not a CI blocker since the commit-msg hook validates format only, not semantic accuracy, but it adds minor confusion in git log. docs: or chore: would be more accurate.

Architecture compliance

  • [✅] No new unsafe outside plumb-cdp
  • [✅] No new unwrap / expect / panic! in library crates
  • [✅] No new println! / eprintln! outside plumb-cli
  • [✅] No new wall-clock or HashMap in observable-output paths
  • [✅] No new todo! / unimplemented! / dbg!

All checks pass trivially — the entire diff is one markdown line.


Anti-pattern scan

Pattern Status Details
Commented-out code ✅ clean
Open-ended TODO markers ✅ clean
Orphaned shims ✅ clean
AI-writing in docs ✅ clean Short noun phrase; humanizer N/A (not docs/src/**)

Quality assessment

The change is a single correctly-placed bullet under ## [Unreleased] / ### Added. No released sections were modified. release-please will include this line in the next automated release entry, which is the accepted project convention.

The only substantive concern is the existing accumulation of test-proof entries in the changelog (v3 autonomous full-flow proof, v3 ACP-allowed proof, now v3.1.1 ignoreOtherMentions proof). These violate the "user-visible only" intent of the CHANGELOG but the pattern is established and deliberate — it's being used as a workflow verification mechanism. A dedicated ## [Internal / Test Proofs] section or a separate file would prevent these from appearing in the public release notes, but that is a separate tracking issue, not a blocker for this PR.


Scope check


Punch list:

  1. CHANGELOG.md:15v3.1.1 ignoreOtherMentions proof (and the two preceding test-proof entries) should be cleaned up or moved out of the user-visible release notes before the 0.0.2 release cut. File a tracking issue if not already open.
  2. PR title: consider docs: or chore: over test: for future changelog-only commits.

Neither item is a blocker in isolation.


Verdict: APPROVE

@aram-devdocs
aram-devdocs merged commit 3fe44e3 into main Apr 29, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: v3.1.1 talking-stick (ignoreOtherMentions)

1 participant