Skip to content

Conversation

@ajanikow
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 28, 2025
@ajanikow ajanikow requested a review from Copilot October 28, 2025 12:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies by regenerating code with newer versions of protoc and code-generation tools. The changes primarily affect generated Kubernetes client code and listers, updating import aliases and adopting new code generation patterns.

  • Updated protoc version from v3.21.1 to v6.33.0
  • Refactored import aliases to use qualified package names (e.g., storagev1alpha, schedulerv1beta1)
  • Migrated fake client implementations to use gentype.FakeClientWithList patterns

Reviewed Changes

Copilot reviewed 50 out of 224 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/platform/inventory/inventory.pb.go Updated protoc version comment in generated protobuf code
pkg/generated/listers/storage/v1alpha/arangolocalstorage.go Changed import alias from v1alpha to storagev1alpha and added explicit aliases for k8s packages
pkg/generated/listers/scheduler/v1beta1/*.go Updated import aliases from v1beta1 to schedulerv1beta1 across all scheduler lister files
pkg/generated/listers/replication/v*/*.go Changed import aliases to include package prefix (e.g., replicationv1, replicationv2alpha1)
pkg/generated/listers/platform/v*/*.go Updated import aliases to platformv1alpha1 and platformv1beta1
pkg/generated/informers/externalversions//.go Changed import aliases to prefix API packages with apis (e.g., apisschedulerv1beta1)
pkg/generated/clientset/versioned/typed//fake/.go Migrated fake clients from manual implementations to gentype.FakeClientWithList
pkg/generated/clientset/versioned/typed//.go Updated NegotiatedSerializer to use rest.CodecFactoryForGeneratedClient
Comments suppressed due to low confidence (1)

pkg/platform/inventory/inventory.pb.go:1

  • The protoc version v6.33.0 appears to be invalid. As of January 2025, the latest protoc version is in the v3.x or v4.x range. Version 6.33.0 does not exist in the official protobuf releases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ajanikow ajanikow merged commit a12e884 into master Oct 28, 2025
4 checks passed
@ajanikow ajanikow deleted the maintenance/bump_deps_2025_10_28 branch October 28, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants